Some minor fixes for Server-Side Rendering (OpenGL)

[ubamrein]

• Add includes in header files (cstring, memory, mutex and so on)
• remove const in vector since it is non standard compliant
• add switches for OpenGL (Serverside) build (ANDROID includes too much)

Summary by CodeRabbit

• New Features

  • Introduced a destroy method across various interfaces and classes for proper cleanup.
  • Updated version to 1.5.3 for the app and associated libraries.

• Enhancements

  • Improved map loading performance with updated DataLoader initialization.
  • Streamlined map view cleanup with enhanced onDestroy behavior.
  • Optimized task scheduling with local scheduler variable usage.

• Bug Fixes

  • Fixed potential null reference issues in task scheduling logic.

• Documentation

  • Updated library version in readme.md files for both Android and iOS.

• Refactor

  • Removed redundant code and improved null handling in callback setting.
  • Enhanced conditional compilation directives for better platform support.

• Style

  • Standardized method signatures by removing const qualifiers from std::vector parameters.

[coderabbitai[bot]]

Walkthrough

The update primarily revolves around version increments from 1.5.1 to 1.5.3 across various files, the addition of a destroy method to gracefully handle object destruction, and the enhancement of null safety and efficiency in task scheduling. There's also a notable shift towards optional parameters and the conditional inclusion of headers for different build environments, indicating a move towards more robust and platform-aware code.

Changes

Files	Summary
android/gradle.properties, android/readme.md, ios/readme.md, shared/src/MapsCoreSharedModule.cpp	Version updated from 1.5.1 to 1.5.3.
android/src/.../DataLoader.kt, android/src/.../AndroidScheduler.kt, android/src/.../MapView.kt, bridging/.../map/MapInterface.kt, bridging/.../map/scheduling/SchedulerInterface.kt, bridging/.../NativeMapInterface.cpp, bridging/.../NativeSchedulerInterface.cpp, bridging/.../NativeSchedulerInterface.h, ios/.../MCMapInterface+Private.mm, ios/.../MCMapInterface.h, ios/.../MCSchedulerInterface+Private.mm, ios/.../MCSchedulerInterface.h, djinni/.../core.djinni, djinni/.../task_scheduler.djinni, ios/.../MCScheduler.swift, shared/public/MapInterface.h, shared/public/SchedulerInterface.h, shared/src/.../MapScene.h	Addition of destroy method and related changes for object destruction.
android/src/.../AndroidScheduler.kt, bridging/.../map/MapInterface.kt, shared/src/.../MapScene.cpp, shared/src/map/layers/.../*	Refactoring for improved null safety and task scheduling efficiency.
shared/public/BoundingBox.h, shared/public/LineHelper.h, shared/public/CoordinateConversionHelper.h, shared/public/IconLayer.h, shared/public/WmtsTiled2dMapLayerConfig.h, shared/src/graphics/SceneInterface.cpp, shared/src/map/MapInterface.cpp, shared/src/logger/Logger.cpp	Conditional inclusion of headers for different build environments.
shared/public/Tiled2dMapRasterLayer.h, shared/public/Tiled2dMapSource.h, shared/public/Tiled2dMapSourceImpl.h, shared/public/Tiled2dMapVectorLayer.h, shared/public/Tiled2dMapVectorStyleParser.h, shared/public/Value.h	Removed const qualifier from std::vector parameters or member types.

Poem

In code's green field, hop I with glee, 🐇 For version bumps and memory free. With destroy added, no leaks to see, 🌱 A tidier pasture for you and me.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.