openmm-plumed icon indicating copy to clipboard operation
openmm-plumed copied to clipboard

Update the build system and fix CI

Open raimis opened this issue 1 year ago • 8 comments

  • [x] Build system
    • [x] Set the project name
    • [x] Use official FindOpenCL (https://cmake.org/cmake/help/latest/module/FindOpenCL.html)
  • [x] CI
    • [x] Fix for Ubuntu 22.04
    • [x] Test multiple versions
    • [x] Clean up

raimis avatar Mar 06 '23 15:03 raimis

@peastman I cannot revive the MacOS tests. The is an issue with OpenCL tests and I cannot fix it. Any ideas about how to fix?

raimis avatar Mar 29 '23 15:03 raimis

We shouldn't be installing pocl on Mac. There's no need, since OpenCL is built into the OS. The first thing I'd try is removing it.

peastman avatar Mar 29 '23 18:03 peastman

@peastman I have remove pocl for MacOS, but now the OpenCL test fail because

exception: No compatible OpenCL platform is available

raimis avatar Apr 24 '23 10:04 raimis

Do you know what kind of GPU the runner has? Perhaps it's configured in a way that prevents it from accessing the GPU?

When running OpenMM CI builds on Mac, we build the OpenCL platform but don't run any tests for it. I don't remember why. Possibly it was for the same reason?

peastman avatar Apr 24 '23 15:04 peastman

I have disabled the OpenCL test on MacOS. I have no experience with MacOS to fix that.

raimis avatar Apr 25 '23 12:04 raimis

@peastman could you review?

raimis avatar Apr 25 '23 12:04 raimis

With OpenMM plugins, we generally don't want to pin the builds to a particular OpenMM version. Every release of the plugin is designed to work with one particular OpenMM release. We don't try to maintain compatibility with older releases, which often isn't possible. And if a new OpenMM release breaks compatibility, we want CI builds of the plugin to start failing immediately so we know we need to update it.

peastman avatar Apr 25 '23 16:04 peastman

Ideally, we should build tests against the night builds (if ones still exist) of OpenMM. If we notice an incompatibility after the next OpenMM release, it is a bit too late.

raimis avatar May 05 '23 09:05 raimis