openmm-cookbook icon indicating copy to clipboard operation
openmm-cookbook copied to clipboard

Published 20 hours ago • verified publisher icon openmm

Turn off PR gh-actions deployment?

Open sef43 opened this issue 1 year ago • 1 comments

Currently when a PR is made a gh-actions workflow tries to build and deploy the PR onto the gh-pages branch so it can be viewed. However, this only works correctly if the PR is made from a branch within the openmm/openmm-cookbook repo. It does not work from any personal forks of the cookbook. This is a github permissions issue which I do not think can be worked around.

As personal forks and PRing is the typical contribution method this gh-actions workflow becomes rather pointless and confusing by throwing workflow errors whenever someone makes a PR.

We could remove it. Or maybe make it only run if the PR comes from within the repo?

sef43 avatar Dec 28 '23 17:12 sef43

How about removing it for PRs, but still running it on the main branch after it is merged?

peastman avatar Dec 28 '23 21:12 peastman