openml-python icon indicating copy to clipboard operation
openml-python copied to clipboard

Allow prob-based metrics to work

Open pseudotensor opened this issue 3 years ago • 1 comments

What does this PR implement/fix? Explain your changes.

Handling probabilities with some metrics

How should this PR be tested?

code here: https://github.com/openml/openml-python/issues/1139

Any other comments?

pseudotensor avatar Jun 01 '22 04:06 pseudotensor

Thanks for the contribution 🎉 I'll try to have a closer look next week. In the meantime, please have a look at the pull request checklist and fill in the missing gaps, such as:

  • add the new parameter to the docstring
  • create unit tests, in particular also ones that would fail before this PR but succeed after
  • add a note to the progress log

PGijsbers avatar Jun 02 '22 11:06 PGijsbers

Closing this because it is stale. In another rework we will probably base it on scikit-learn scorer objects instead of the metric function so that we have access to whether it needs proba directly instead of as an additional argument.

PGijsbers avatar Feb 20 '23 16:02 PGijsbers