openml-python icon indicating copy to clipboard operation
openml-python copied to clipboard

Code coverage fails

Open Neeratyoy opened this issue 3 years ago • 3 comments

Description

Codecov is currently being triggered for Python 3.8, for Scikit-learn 0.23.1.

Expected Results

The coverage statistics are successfully updated.

Actual Results

The coverage instance fails in Github Actions.

Neeratyoy avatar Mar 15 '21 14:03 Neeratyoy

If I recall correctly this may have had to do with the unit test clean up also removing the coverage file before upload.

PGijsbers avatar Mar 15 '21 14:03 PGijsbers

As you mentioned, it does appear to be a case of the missing coverage file. However, on local tests, the coverage.xml is being generated while running pytest. Probably the Github Actions flow cannot either detect the file or not find content in it, or I wonder if this some path issue too.

Neeratyoy avatar Mar 15 '21 21:03 Neeratyoy

I remember working on this and seeing the coverage file get deleted on my system by test clean up (because they clean all new files from openml instead of openml/tests/files/). Weird thing I can't find any branch for this. I also don't remember when exactly this is, so it might have been an issue that has been fixed and this is now a new issue 😓

PGijsbers avatar Mar 16 '21 08:03 PGijsbers