openml-python icon indicating copy to clipboard operation
openml-python copied to clipboard

Published 20 hours ago • verified publisher icon openml

Allow loose reinitialization from runs also

Open PGijsbers opened this issue 5 years ago • 5 comments

See #1005.

If someone is able to complete this PR (e.g. add unit tests), then that would be greatly appreciated. Otherwise this will go stale for at least two weeks. Maybe @Neeratyoy ?

PGijsbers avatar Nov 18 '20 07:11 PGijsbers

Sure, I can take this up. If not this week, next week for sure. To clarify, the main to-do would be to have some unit tests that work across sklearn versions with the strict version parameter set to False ?

Neeratyoy avatar Nov 18 '20 10:11 Neeratyoy

For this PR, that would be the extent of it. In general we need more documentation for the extension but that can also be a separate PR later (possibly even by someone else).

PGijsbers avatar Nov 18 '20 21:11 PGijsbers

Alright, I think I shall address this next week from Monday!

Neeratyoy avatar Nov 19 '20 12:11 Neeratyoy

Sorry this went off my radar. It looks like the added test fails?

PGijsbers avatar Feb 11 '21 11:02 PGijsbers

My bad. I made this push as a potential design for how the unit test can be written, wasn't expecting it to pass. Moreover, I think this PR needs to be rebased first. I am working on some other things, for now, targeting a release this week. Will pick this up hopefully next week!

Neeratyoy avatar Feb 15 '21 20:02 Neeratyoy