OpenML icon indicating copy to clipboard operation
OpenML copied to clipboard

Bugfix/update docker php limits

Open josvandervelde opened this issue 5 months ago • 2 comments

Updated the php settings to similar values as production.

The main time-drain was garbage collection. On production, /usr/lib/php/sessionclean is ran from crontab but.. it does not clean the code igniter sessions! Those sessions are only cleaned after a reboot:

[user]@openml2:~$ find /tmp -name "ci_session*" -type f -printf '%T+ %p\n' | sort | head -n 5 2>/dev/null
2025-04-14+13:01:16.5844657760 /tmp/ci_sessionib0csl6lo5l776dd19ee0vcbv41jff9t
2025-04-14+13:01:19.2861908390 /tmp/ci_sessionh5cvaku1esmps8o0pv0nsl7gh43rccnd
2025-04-14+13:01:19.7101894730 /tmp/ci_session51jqq0h2gnh0bq4f4vse6239efjhrrac
2025-04-14+13:01:19.7861892280 /tmp/ci_sessionv2ebsskm2lveutqcfg0eh9o9c15bhr07
2025-04-14+13:01:19.8541890090 /tmp/ci_sessioniqadqra76osd3vvcp9d1fh7b5i97o9vu

[user]@openml2:~$ uptime
 up 97 days

I did not fix this on current production. It is now fixed for the new deployment, as far as I can see. I tested it by setting session.gc_maxlifetime=10 (seconds) and using openml-services (docker compose).

It would be great if anyone with some knowledge of PHP and Code Igniter garbage collection / session handling could take a look at this!

josvandervelde avatar Jul 20 '25 14:07 josvandervelde

Hi @janvanrijn @joaquinvanschoren , it would be great if you could review this! These settings should be production-ready.

josvandervelde avatar Jul 25 '25 10:07 josvandervelde

Looks good. This is only for docker, right? It doesn't affect the currently running production server?

joaquinvanschoren avatar Aug 06 '25 05:08 joaquinvanschoren