openmc icon indicating copy to clipboard operation
openmc copied to clipboard

Ensuring only exact "vacuum" assignment is detected as vacuum

Open bam241 opened this issue 1 year ago • 3 comments

Description

This is a follow up on svalinn/DAGMC#805

This ensures that a assignment named "not_a_vacuum" is not flagged as vacuum and therefore is not assigned with vacuum boundary condition.

Fixes # (issue) This is related to #3218

I also had to implement that a different way than initially expected. I first thought about leveraging the #3056 PR recently merged to do this kind of test. But, vacuum detection is perform (in the DAGMC workflow within openMC) before applying materials assignment (therefore before overriding)

This is why I implemented this by making temporary copy of the dagmc.hm5 and modifying them. (Not that seing how simple this is we could potentially provide a method that allows to do that within dagmc.py ?)

I trying and failed to design this test as a fixture, I don't know why it failed it never recognised the returned model as a openmc.Model but as a function... (@pshriwise if you have any insight on this ?)

Checklist

  • [x] I have performed a self-review of my own code
  • [x] I have run clang-format (version 15) on any C++ source files (if applicable)
  • [x] I have followed the style guidelines for Python source files (if applicable)
  • [x] I have added tests that prove my fix is effective or that my feature works (if applicable)

This works is sponsored by Proxima Fusion

bam241 avatar Jan 15 '25 09:01 bam241

yes it does ! I didn't know I could check presence of a material like that, it is great. I'll add some more assert to exactly match what I wanted to test, but thx for the suggestion !

bam241 avatar Jan 23 '25 09:01 bam241

Sweet! I'll keep an eye out for your updates!

pshriwise avatar Jan 23 '25 15:01 pshriwise

@pshriwise I finally got the time to get back to it.

The goal here, is to make sure, a material assignment named "vacuum" is empty and one named "not_a_vacuum" is properly defined. (this is a follow-up test to ensure the former DAGMC behaviour flagging any assignment with vacuum in it as vacuum)

bam241 avatar Apr 12 '25 09:04 bam241