openmc icon indicating copy to clipboard operation
openmc copied to clipboard

Add dose coefficients from ICRP 74

Open MatteoZammataro opened this issue 1 year ago • 1 comments

This PR is related to issue #2516, and it's an extension of PR #2749. It adds H*(10) dose coefficients from ICRP 74. We're introducing a new function, "dose_coefficients()."

This function has a "data_source" argument, which you can set to icrp74, icrp116, or icrp119 (the default is icrp116). This allows for using both effective and ambient dose coefficients. When you use the effective dose ones, the syntax is basically the same as before.

Any suggestions for improvement are welcome.

I would like to extend my gratitude to @shimwell for his contributions to this topic thus far.

MatteoZammataro avatar May 30 '24 14:05 MatteoZammataro

Looks good to me, I wasn't sure if PR #2749 was useful to anyone. Happy to see it might be useful.

shimwell avatar May 30 '24 19:05 shimwell

@paulromano If you are not available, could you please suggest another independent reviewer?

MatteoZammataro avatar Oct 04 '24 08:10 MatteoZammataro

@MatteoZammataro sorry I haven't had a chance to look at this yet. As you've probably figured, I'm working to get through the backlog of PRs and will take a look at this shortly.

paulromano avatar Oct 04 '24 16:10 paulromano

@paulromano Thanks for your review! I've changed the neutron data, they now come from table A.41. To be consistent, I also changed the photon data by multiplying the coefficients from Table A.1 (photon fluence to kerma) by the coefficients from A.17 (photon kerma to effective dose). I understand that this was not requested, so I'll remove it if you don't think it's necessary.

I would also like to point out that using the data from A.41 and A.17, we again provide fluence to effective dose coefficients. It would be useful to also implement the ambient dose coefficients (from Table A.42 for neutrons and A.21 for photons). Ambient dose coefficients can be useful for many radiation protection studies.

MatteoZammataro avatar Oct 08 '24 09:10 MatteoZammataro