openmc icon indicating copy to clipboard operation
openmc copied to clipboard
verified publisher icon openmc-dev

Replace centroid() with vertex_average().

Open aprilnovak opened this issue 4 years ago • 8 comments

Replace centroid() with vertex_average() to prepare for future deprecation.

Closes #1914

aprilnovak avatar Nov 22 '21 21:11 aprilnovak

Looks like CI is failing because the version of libmesh is pinned at 1.6.0: https://github.com/openmc-dev/openmc/blob/f0aa6664b3d6836baf688f53267a5fa301693279/tools/ci/gha-install-libmesh.sh#L8

paulromano avatar Nov 23 '21 04:11 paulromano

I did notice that yesterday and force pushed with that file changed - it looks like CI is now pulling 1.6.2, but still not passing...

aprilnovak avatar Nov 23 '21 14:11 aprilnovak

When looking at the release notes for libMesh, I don't see this switch happening until v1.7.0 . 1.7.0 is still pending release as v1.7.0-rc3. Looks like we'll need to wait a bit until we can check out the stable v1.7.0 version of libmesh in CI?

pshriwise avatar Nov 23 '21 21:11 pshriwise

@aprilnovak It looks like this PR could be revived now that libmesh 1.7.0 (and 1.7.1) have been released. Do you want to take a shot at updating this?

paulromano avatar Jul 14 '22 18:07 paulromano

Sure thing! Will get to this soon.

aprilnovak avatar Jul 14 '22 18:07 aprilnovak

Just wanted to ping you on this @aprilnovak. We're going to try to get a release out soon -- probably would make sense to include this in the release too

paulromano avatar Jul 28 '22 23:07 paulromano

Is there something else that needs to be done on this PR? I updated it 2 weeks ago and I believe it's ready-to-go. Sorry for not notifying you at the time, figured you'd do another sweep :)

aprilnovak avatar Jul 29 '22 00:07 aprilnovak

Sorry for the noise, I didn't realize you had updated this :smile: As we discussed offline, let's hold off on merging this until after we do a release.

paulromano avatar Aug 03 '22 03:08 paulromano