openmc icon indicating copy to clipboard operation
openmc copied to clipboard

Continuously Varying Material Tracking Method (CVMT) Implementation

Open rockfool opened this issue 6 years ago • 8 comments
trafficstars

This PR is to add CVMT method in the particle tracking. It allows the nuclides number densities in Material class be expressed by the functional expansion. However, the functional expansion tallied nuclides number densities is not determined. Any comment will be appreciated. I am also preparing the testing cases for this implementaion.

rockfool avatar Sep 20 '19 17:09 rockfool

Just wondering, how does this method generally perform compared to delta tracking?

gridley avatar Sep 25 '19 00:09 gridley

Just wondering, how does this method generally perform compared to delta tracking? This method was come up as the alternate way of delta-tracking to sample the particle flight path in the medium with continously varying cross sections. However, delta-tracking might meet with low sampling efficiency issue and the track-length estimator issue. This is a direct sampling method, and has the most compatibility with ray-tracking.
[1]. Brown, Forrest B., and William R. Martin. "Direct sampling of Monte Carlo flight paths in media with continuously varying cross-sections." In Proc. ANS Mathematics & Computation Topical Meeting, vol. 2. 2003.

rockfool avatar Sep 25 '19 02:09 rockfool

Just wondering, how does this method generally perform compared to delta tracking? Delta-tracking could be faster than this direct sampling when XS doesn't vary too much in the domain. When both continuous number density and continuous XS sections are involved, it might be harder to evaluate maximum macroscopic XS.

hanzhuoran avatar Sep 25 '19 02:09 hanzhuoran

Interesting, thanks for the replies guys. Has anyone tried making this hybrid with delta tracking, kind of like how Serpent does hybrid delta tracking and ray tracing?

gridley avatar Sep 25 '19 02:09 gridley

Interesting, thanks for the replies guys. Has anyone tried making this hybrid with delta tracking, kind of like how Serpent does hybrid delta tracking and ray tracing?

As I know, none of us is working on the delta-tracking or hybrid with delta-tracking currently.

rockfool avatar Sep 25 '19 02:09 rockfool

Thanks for the PR @rockfool. This branch looks like it needs considerable clean-up before it would be ready for review. Please have a look at our C++ style guide and try to conform to it. I also do not see any tests or documentation which will be needed as well. Once this has been cleaned up and tests/docs added, ping me for a review again. Thanks!

Thanks for your comments. I am going to remove those stuff that does not conform to C++ style, and try to prepare a testing case and the documentation in docs/neutron_physics.rst.

rockfool avatar Sep 30 '19 23:09 rockfool

Hi @rockfool. Just wanted to check in regarding this PR. If you'd like me to review this one again, please update it by merging the develop branch in order to resolve the existing merge conflicts.

paulromano avatar Jan 27 '20 13:01 paulromano

Hi @rockfool. Just wanted to check in regarding this PR. If you'd like me to review this one again, please update it by merging the develop branch in order to resolve the existing merge conflicts.

OK. I will try to reovle this conflict ASAP.

rockfool avatar Jan 27 '20 15:01 rockfool