openmaptiles icon indicating copy to clipboard operation
openmaptiles copied to clipboard

Some borders with admin_level <= 2 are missing.

Open hr0109 opened this issue 4 years ago • 9 comments

How to reproduce the problem:

git clone https://github.com/openmaptiles/openmaptiles.git
cd openmaptiles
make
./quickstart.sh taiwan

The output mbtiles should be like this: Screenshot 2021-10-10 111049

The correct mbtiles should be like this:(maptiler-osm-2017-07-03-v3.6.1-planet.mbtiles downloaded from maptiler.com) Screenshot 2021-10-10 111513

You can see some borders are missing. Any idea to fix the problem? Thanks

hr0109 avatar Oct 10 '21 03:10 hr0109

Usually this occurs when the bounding polygon used by geofabrik extracts clips part of the boundary. You should email [email protected] to get this corrected on their side.

ZeLonewolf avatar Oct 10 '21 08:10 ZeLonewolf

Usually this occurs when the bounding polygon used by geofabrik extracts clips part of the boundary. You should email [email protected] to get this corrected on their side.

Clipping polygon used by Geofabrik.de: Screenshot 2021-10-10 185458

The boundary seems to remain completed in the pbf file: Screenshot 2021-10-10 190838

It seems that it`s not Geofabrik`s problem.

hr0109 avatar Oct 10 '21 11:10 hr0109

Thanks for the analysis, we'll need to dig deeper.

ZeLonewolf avatar Oct 10 '21 16:10 ZeLonewolf

It appears that the issue is that there are several islands in the Taiwan boundary relation that are well outside the data file clipping area: image

Unfortunately, imposm will drop objects that are not fully present in the source data file, which is why you're seeing this issue.

ZeLonewolf avatar Oct 14 '21 01:10 ZeLonewolf

I have done 2 cuts for the area @hr0109 is looking at using an older clone of the repository (from 2 weeks ago) and a latest clone from last night. Here is the result:

Old code from 2 weeks ago: image

Latest code: image

Were there some changes with import-borders?

ache051 avatar Oct 14 '21 20:10 ache051

Yes, #1213

ZeLonewolf avatar Oct 14 '21 20:10 ZeLonewolf

Could you please also check, if the borders are correctly imported into the database? Just trying to figure out, if the borders are not imported into the database (by import-osm) or are dropped by SQL in the boundary layer.

TomPohys avatar Mar 13 '23 10:03 TomPohys