software-discovery-tool icon indicating copy to clipboard operation
software-discovery-tool copied to clipboard

Flake8 integration for Linting

Open xtanion opened this issue 2 years ago • 3 comments

[WIP] Creating an initial draft for the flake8 integration in Software Discovery Tool TODO:

  • [x] Setting up GitHub workflows
  • [ ] Moving the entire codebase to follow Flake8

Please take a look @pleia2 @arshPratap

xtanion avatar May 16 '23 10:05 xtanion

Hi @pleia2, Sorry for messaging you this late. We should merge this PR first since we've decided to move forward with the Flake8 linting format. It'll add the GitHub workflow. Initially, I was planning to change everything in just one PR, but it'll be a hassle to review manually & if we've flake8 workflow already set up, I'll do half of the jobs for us (that is, checking the PR). Please let me know your thought on this. Thanks.

xtanion avatar May 19 '23 04:05 xtanion

No decision has been made regarding linting format or other coding standards. Please bring this up at the team meeting on Tuesday, May 23rd.

pleia2 avatar May 19 '23 15:05 pleia2

Details for our upcoming meeting, where we can discuss this, can be found on our calendar: https://lists.openmainframeproject.org/g/software-discovery-tool-discussion/calendar

pleia2 avatar May 22 '23 16:05 pleia2