feilong icon indicating copy to clipboard operation
feilong copied to clipboard

Added support for custom cpu share

Open santhosh-sloka opened this issue 1 year ago • 2 comments

To Support CPU share in case " https://github.ibm.com/zvc/planning/issues/18693 "

--signed off : [email protected]

santhosh-sloka avatar Aug 05 '24 18:08 santhosh-sloka

Dear @SeanHQF @jichenjc - This is the dependency PR for " https://github.ibm.com/zvc/nova-icic/pull/102 ", will do final test and update here for review and merge, thanks.

santhosh-sloka avatar Aug 05 '24 18:08 santhosh-sloka

@bjhuangr pls review

SeanHQF avatar Aug 06 '24 02:08 SeanHQF

@santhosh-sloka the code you made is inconsistent to the code code is for comments and you said here it's for cpu share

please confirm

jichenjc avatar Aug 06 '24 03:08 jichenjc

@santhosh-sloka the code you made is inconsistent to the code code is for comments and you said here it's for cpu share

please confirm

hi @jichenjc - As this is part of the CPU share feature, I have added that comment, moreover we are changing 2 files, in one we are adding the comments, in the validation parameter file, we are adding support to include custom cpu share ..

santhosh-sloka avatar Aug 06 '24 04:08 santhosh-sloka

@jichenjc @SeanHQF - We are testing the existing scenario , will confirm by this week or the merger of PR : https://github.com/openmainframeproject/feilong/pull/834, https://github.com/openmainframeproject/feilong/pull/833 and https://github.ibm.com/zvc/nova-icic/pull/102

santhosh-sloka avatar Aug 07 '24 06:08 santhosh-sloka

Update :

Have added validation of share ABS and all its combination, REL and all its combination, ABS value to validate decimal etc .

This is good to merge, we have finalised the code for " https://github.ibm.com/zvc/nova-icic/pull/102 " correcting some UT failures, once fixed both can be merged at one go, thanks ..

@SeanHQF , @jichenjc

santhosh-sloka avatar Aug 09 '24 16:08 santhosh-sloka

@bjhuangr - FYI ..

santhosh-sloka avatar Aug 13 '24 10:08 santhosh-sloka