ol-mapbox-style icon indicating copy to clipboard operation
ol-mapbox-style copied to clipboard

Published 20 hours ago • verified publisher icon openlayers

Use maplibre instead of mapbox style spec

Open ahocevar opened this issue 1 year ago • 6 comments

I'm putting this up for discussion, as an alternative to #939.

The one thing that makes me hesitant to make this change is that I don't know what the plans are for Maplibre to stick with or depart from the Mapbox style spec. If someone from @maplibre, maybe @birkskyum, could comment on that, it would make the decision easier.

ahocevar avatar Jun 30 '23 12:06 ahocevar

Sure, since the Mapbox style spec has become proprietary, the plan for MapLibre is to continue developing the MapLibre Style Spec independently from Mapbox. The main divergence has so far been around atmosphere / globe features which were added after the fork, but the two style specs are still largely identical, and most changes happen as backwards-compatible additions, with both style specs still being on version 8.x.

birkskyum avatar Jun 30 '23 12:06 birkskyum

@ahocevar It appears that new versions of @mapbox/mapbox-gl-style-spec will also fall under the proprietary license as of this commit: https://github.com/mapbox/mapbox-gl-js/commit/a02c71b7ebacbbe6ccf4279edd6dc2399f85a995. So switching to MapLibre Style Spec seems like a good idea moving forward.

mbeckem avatar Sep 15 '23 08:09 mbeckem

@mbeckem Thanks for the pointer!

If you are interested in using this module in a manner not expressly permitted by its license, please do not hesitate to contact [email protected] with details of what you have in mind.

I'll do this first, and see what the options are.

ahocevar avatar Sep 15 '23 08:09 ahocevar

I'm in favour of moving over to @maplibre/maplibre-gl-style-spec, reasons being:

  • we have an opportunity to discuss any changes with the maplibre team (because it's public)
  • the maplibre spec is open source, no issues with licensing
  • I'm personally building a tool on-top of maplibre/openlayer :smile:

orangemug avatar Dec 13 '23 16:12 orangemug

Since I got no satisfying answer from Mapbox, I'm inclined to go in that direction too. But it's also tempting to create a new package, independent of both Mapbox and Maplibre, with a few more useful features (profiles, auto-generated docs, optimized for build size).

ahocevar avatar Dec 13 '23 20:12 ahocevar

@ahocevar the spec is in progress over at https://github.com/maparatus/ol-mapbox-style-spec, rendered spec at https://maparatus.github.io/ol-mapbox-style-spec/ (I'll continue to update issue #10 on progress).

That's based on the maplibre-gl spec. I'm happy to transfer that repository over once I complete the tests and update the spec.

From my perspective. It'd be fine to merge this in the meantime, as it'd be closer to the incoming spec work.

orangemug avatar Dec 14 '23 08:12 orangemug