ethers-gcp-kms-signer

ethers-gcp-kms-signer copied to clipboard

toolchainx

First of all, thank you for this great library. It's been critical to my company's operation! I am trying to upgrade the code base to use ethers.js v6. Will it...

charlie-kim

Intermittent "invalid point" error when signing a transaction

8

I'm getting frequent yet intermittent "invalid point" errors when using v1.1.2 to sign a transaction. The signing algorithm for the asymmetric signing key in GCP KMS is Elliptic Curve P-256...

nedgar

KeyManagementServiceClient is leaked on each call to sign or getPublicKey

1

In `src/util/gcp-kms-utils.ts` it instantiates a new `KeyManagementServiceClient` each time `sign` or `getPublicKey` is called. See: https://github.com/openlawteam/ethers-gcp-kms-signer/blob/45a5186c9b3f27bd2bcf5c53bef138fe3fb43c24/src/util/gcp-kms-utils.ts#L25 https://github.com/openlawteam/ethers-gcp-kms-signer/blob/45a5186c9b3f27bd2bcf5c53bef138fe3fb43c24/src/util/gcp-kms-utils.ts#L43 The client maintains a gRPC channel, plus one in its referenced IAM client....

nedgar

The version of protobufjs being used has a critical vulnerability. Can we get this updated? Path: ethers-gcp-kms-signer > @google-cloud/kms > google-gax > protobufjs Patched in : >=7.2.5 ``` protobuf.js (aka...

farhankhwaja