rollouts icon indicating copy to clipboard operation
rollouts copied to clipboard

fix: lua encode structural error

Open ls-2018 opened this issue 10 months ago • 3 comments

Ⅰ. Describe what this PR does

Pass an object to lua for modification, and the resulting return value. After serialization the field type changed.  
if not fix, the jsonBytes whill be 

 {"metadata":[],"spec":{"containers":[{"image":"centos:7","name":"centos","resources":[]}]},"status":[]}
  • metadata
  • status
  • resources

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

ls-2018 avatar Apr 03 '24 06:04 ls-2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot avatar Apr 03 '24 06:04 kruise-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.83%. Comparing base (07c1731) to head (f794fe8). Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   43.63%   43.83%   +0.19%     
==========================================
  Files          52       52              
  Lines        5681     5681              
==========================================
+ Hits         2479     2490      +11     
+ Misses       2778     2765      -13     
- Partials      424      426       +2     
Flag Coverage Δ
unittests 43.83% <100.00%> (+0.19%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 03 '24 06:04 codecov[bot]

/lgtm

zmberg avatar Apr 09 '24 02:04 zmberg

/lgtm /approve

furykerry avatar Sep 06 '24 01:09 furykerry