kruise
kruise copied to clipboard
Proposal: support multi-version daemonset
Ⅰ. Describe what this PR does
Sometimes users may want to upgrade some daemon pods to version 1.1 and others to version 1.2 on specified nodes. For example, upgrade daemon pods in different CPU architecture nodes independently. A UnitedDaemonSet which is related to the existing DaemonSet can help users to achieve that. The controller will distribute multi-version pods of the existing DaemonSet according to UnitedDaemonSet subsets configuration.
Ⅱ. Does this pull request fix one issue?
None
Ⅲ. Describe how to verify it
None
Ⅳ. Special notes for reviews
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign furykerry after the PR has been reviewed.
You can assign the PR to them by writing /assign @furykerry
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Welcome @LinFCai! It looks like this is your first PR to openkruise/kruise 🎉
Codecov Report
Merging #959 (a82fd2b) into master (5b52b6e) will decrease coverage by
0.03%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
- Coverage 49.99% 49.96% -0.04%
==========================================
Files 119 119
Lines 11535 11535
==========================================
- Hits 5767 5763 -4
- Misses 4896 4898 +2
- Partials 872 874 +2
Flag | Coverage Δ | |
---|---|---|
unittests | 49.96% <ø> (-0.04%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/cloneset/cloneset_controller.go | 54.15% <0.00%> (-2.38%) |
:arrow_down: |
pkg/controller/daemonset/daemonset_update.go | 55.75% <0.00%> (+0.88%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5b52b6e...a82fd2b. Read the comment docs.
@FillZpp @furykerry we want to add a CRD to deploy multi-version daemon pods on different nodes and this is our idea, thanks.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@LinFCai You can you join the community meetings to discuss this.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.