kruise icon indicating copy to clipboard operation
kruise copied to clipboard

Proposal: support multi-version daemonset

Open LinFCai opened this issue 2 years ago • 6 comments

Ⅰ. Describe what this PR does

Sometimes users may want to upgrade some daemon pods to version 1.1 and others to version 1.2 on specified nodes. For example, upgrade daemon pods in different CPU architecture nodes independently. A UnitedDaemonSet which is related to the existing DaemonSet can help users to achieve that. The controller will distribute multi-version pods of the existing DaemonSet according to UnitedDaemonSet subsets configuration.

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Describe how to verify it

None

Ⅳ. Special notes for reviews

None

LinFCai avatar Apr 20 '22 09:04 LinFCai

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign furykerry after the PR has been reviewed. You can assign the PR to them by writing /assign @furykerry in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot avatar Apr 20 '22 09:04 kruise-bot

Welcome @LinFCai! It looks like this is your first PR to openkruise/kruise 🎉

kruise-bot avatar Apr 20 '22 09:04 kruise-bot

Codecov Report

Merging #959 (a82fd2b) into master (5b52b6e) will decrease coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
- Coverage   49.99%   49.96%   -0.04%     
==========================================
  Files         119      119              
  Lines       11535    11535              
==========================================
- Hits         5767     5763       -4     
- Misses       4896     4898       +2     
- Partials      872      874       +2     
Flag Coverage Δ
unittests 49.96% <ø> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/cloneset_controller.go 54.15% <0.00%> (-2.38%) :arrow_down:
pkg/controller/daemonset/daemonset_update.go 55.75% <0.00%> (+0.88%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b52b6e...a82fd2b. Read the comment docs.

codecov-commenter avatar Apr 20 '22 09:04 codecov-commenter

@FillZpp @furykerry we want to add a CRD to deploy multi-version daemon pods on different nodes and this is our idea, thanks.

LinFCai avatar Apr 21 '22 08:04 LinFCai

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 20 '22 23:07 stale[bot]

@LinFCai You can you join the community meetings to discuss this.

FillZpp avatar Jul 21 '22 03:07 FillZpp

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 19 '22 04:10 stale[bot]