kruise icon indicating copy to clipboard operation
kruise copied to clipboard

add ephemeraljob validating webhook

Open ABNER-1 opened this issue 9 months ago • 2 comments

Ⅰ. Describe what this PR does

fix #1614

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Invalid ejob must be rejected by webhook. For example: image

Ⅳ. Special notes for reviews

ABNER-1 avatar May 11 '24 04:05 ABNER-1

Codecov Report

Attention: Patch coverage is 70.33898% with 35 lines in your changes missing coverage. Please review.

Project coverage is 49.16%. Comparing base (0d0031a) to head (7b495c6). Report is 40 commits behind head on master.

Files Patch % Lines
pkg/webhook/ephemeraljob/validating/validation.go 74.48% 18 Missing and 7 partials :warning:
...b/validating/ephemeraljob_create_update_handler.go 58.82% 5 Missing and 2 partials :warning:
pkg/webhook/ephemeraljob/validating/webhooks.go 0.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1615      +/-   ##
==========================================
+ Coverage   47.91%   49.16%   +1.24%     
==========================================
  Files         162      183      +21     
  Lines       23491    18921    -4570     
==========================================
- Hits        11256     9302    -1954     
+ Misses      11014     8398    -2616     
  Partials     1221     1221              
Flag Coverage Δ
unittests 49.16% <70.33%> (+1.24%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 11 '24 04:05 codecov[bot]

/lgtm

zmberg avatar Jun 04 '24 01:06 zmberg

/approve

furykerry avatar Jun 04 '24 08:06 furykerry

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot avatar Jun 04 '24 08:06 kruise-bot