kruise icon indicating copy to clipboard operation
kruise copied to clipboard

[feature request] support structured logging

Open furykerry opened this issue 10 months ago • 5 comments

What would you like to be added: Follow the proposal of kubernetes, OpenKruise should use structured logging instead of unstructured logging and shall output json format if argument --logging-format=json is used. https://kubernetes.io/blog/2020/09/04/kubernetes-1-19-introducing-structured-logs/

Pick a file or directory that you would like to improve and migrate existing log calls to use structured logs. It's a great and easy way to make your first contribution to Kruise!

Why is this needed: OpenKruise currently use unstructured plain text as the logging format, which may logging processing hard.

  • [x] pkg/control
  • [x] pkg/controller
  • [ ] pkg/daemon
  • [ ] pkg/webhook
  • [ ] pkg/util
  • [ ] cmd

furykerry avatar Mar 29 '24 06:03 furykerry

/assign I will try to add structured logging in pkg/control dir, if i do it quickly, I will be pleasure to try other instances.

MajLuu avatar Mar 31 '24 14:03 MajLuu

is this issue open?

manan1979 avatar Apr 24 '24 16:04 manan1979

yes,it is still open, other packages also need structured logging, i've updated the issue to list the packages need structured logging change

furykerry avatar Apr 26 '24 01:04 furykerry

Hi, I want to try pkg/controller for my first commit to Kruise. Is anyone else working on this package?

jairuigou avatar May 20 '24 09:05 jairuigou

/assign @jairuigou

furykerry avatar May 20 '24 09:05 furykerry