kruise
kruise copied to clipboard
feat: JobSidecarTerminator support exec sidecar preStop
Ⅰ. Describe what this PR does
Fix https://github.com/openkruise/kruise/issues/1486
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@hantmac You first resolve the ci, https://github.com/openkruise/kruise/actions/runs/7959327463/job/21726086668?pr=1506
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 48.66%. Comparing base (
5421ee7) to head (fd2b40a). Report is 64 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1506 +/- ##
==========================================
+ Coverage 48.55% 48.66% +0.10%
==========================================
Files 157 157
Lines 22480 22496 +16
==========================================
+ Hits 10916 10948 +32
+ Misses 10360 10348 -12
+ Partials 1204 1200 -4
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 48.66% <100.00%> (+0.10%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@hantmac You first resolve the ci, https://github.com/openkruise/kruise/actions/runs/7959327463/job/21726086668?pr=1506
Thanks! UT fixed.
/hold
@hantmac: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.