kruise icon indicating copy to clipboard operation
kruise copied to clipboard

SidecarSet inject sidecar container to all Pods in some namespaces

Open xiangpingjiang opened this issue 1 year ago • 4 comments

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1368

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

xiangpingjiang avatar Aug 15 '23 08:08 xiangpingjiang

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot avatar Aug 15 '23 08:08 kruise-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.21%. Comparing base (321c991) to head (c7959cc). Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
- Coverage   48.25%   48.21%   -0.04%     
==========================================
  Files         152      152              
  Lines       21469    21476       +7     
==========================================
- Hits        10359    10354       -5     
- Misses       9973     9981       +8     
- Partials     1137     1141       +4     
Flag Coverage Δ
unittests 48.21% <100.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 15 '23 17:08 codecov-commenter

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 06 '23 00:12 stale[bot]

/hold

xiangpingjiang avatar Dec 06 '23 10:12 xiangpingjiang

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 06 '24 02:03 stale[bot]