kruise icon indicating copy to clipboard operation
kruise copied to clipboard

SidecarSet add upgrade state in pod annotation

Open xiangpingjiang opened this issue 1 year ago • 5 comments

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1312

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

xiangpingjiang avatar Jul 28 '23 06:07 xiangpingjiang

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

sonatype-lift[bot] avatar Jul 28 '23 06:07 sonatype-lift[bot]

Codecov Report

Attention: Patch coverage is 38.70968% with 57 lines in your changes missing coverage. Please review.

Project coverage is 49.87%. Comparing base (4e35a1d) to head (40103b6). Report is 119 commits behind head on master.

Files Patch % Lines
pkg/control/sidecarcontrol/util.go 2.63% 37 Missing :warning:
pkg/controller/sidecarset/sidecarset_processor.go 57.44% 16 Missing and 4 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   48.60%   49.87%   +1.26%     
==========================================
  Files         152      160       +8     
  Lines       21333    24759    +3426     
==========================================
+ Hits        10369    12348    +1979     
- Misses       9828    11172    +1344     
- Partials     1136     1239     +103     
Flag Coverage Δ
unittests 49.87% <38.70%> (+1.26%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 28 '23 06:07 codecov-commenter

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot avatar Aug 04 '23 17:08 kruise-bot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 19 '23 04:11 stale[bot]

/open

xiangpingjiang avatar Nov 27 '23 02:11 xiangpingjiang

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 07 '24 04:06 stale[bot]