kruise icon indicating copy to clipboard operation
kruise copied to clipboard

WorkloadSpread consider whether patch field is matched when assign existing pods to subset

Open veophi opened this issue 2 years ago • 4 comments

…subset

Signed-off-by: mingzhou.swx [email protected]

Ⅰ. Describe what this PR does

WorkloadSpread consider whether patch field is matched when assign existing pods to subset

preferredScore = 100 * schedulePreferredScore + 10 * patchPreferredScore + quotaScore

patchPreferredScore ++ if subset.patch.annotations or subset.patch.labels is matched with pod's.

veophi avatar Sep 21 '22 12:09 veophi

/lgtm

furykerry avatar Sep 22 '22 06:09 furykerry

Codecov Report

Merging #1083 (5b16625) into master (4edba53) will decrease coverage by 0.42%. The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
- Coverage   50.24%   49.82%   -0.43%     
==========================================
  Files         126      131       +5     
  Lines       17839    18550     +711     
==========================================
+ Hits         8964     9242     +278     
- Misses       7887     8283     +396     
- Partials      988     1025      +37     
Flag Coverage Δ
unittests 49.82% <81.81%> (-0.43%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../workloadspread/workloadspread_controller_utils.go 83.33% <76.47%> (-4.01%) :arrow_down:
...roller/workloadspread/workloadspread_controller.go 63.52% <100.00%> (-0.16%) :arrow_down:
...ler/podprobemarker/podprobemarker_event_handler.go 0.00% <0.00%> (ø)
...troller/nodepodprobe/nodepodprobe_event_handler.go 0.00% <0.00%> (ø)
...ntroller/nodepodprobe/node_pod_probe_controller.go 59.29% <0.00%> (ø)
pkg/util/finalizer.go 0.00% <0.00%> (ø)
...ller/podprobemarker/pod_probe_marker_controller.go 52.68% <0.00%> (ø)
pkg/controller/statefulset/stateful_set_control.go 63.90% <0.00%> (+0.32%) :arrow_up:
pkg/controller/daemonset/daemonset_update.go 58.28% <0.00%> (+0.92%) :arrow_up:
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 22 '22 10:09 codecov-commenter

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot avatar Sep 23 '22 02:09 kruise-bot