kruise icon indicating copy to clipboard operation
kruise copied to clipboard

rescheduleCriticalSeconds limited to max 98 seconds

Open martin2176 opened this issue 3 years ago • 6 comments

scheduleStrategy: type: Adaptive adaptive: rescheduleCriticalSeconds: 180

Invalid value: 180: rescheduleCriticalSeconds < 0 or rescheduleCriticalSeconds > 98 is not permitted I have 4 subsets . Adding each subset lower the allowed value of reschedulecriticalseconds.

Can we allow user to specify a reasonable time such as 5 minutes.? Cloud Kubernetes deployments take atleast 2 minutes to spin up a node in response to an autoscaler event

martin2176 avatar Sep 09 '22 17:09 martin2176

sounds good

veophi avatar Sep 13 '22 08:09 veophi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 13 '22 01:12 stale[bot]

Will someone triage this and approve/reject ?

martin2176 avatar Dec 13 '22 14:12 martin2176

/reopen

zmberg avatar Dec 22 '22 04:12 zmberg

@zmberg: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kruise-bot avatar Dec 22 '22 04:12 kruise-bot

@caniszczyk I thinks it's good. Can you submit a pr for this?

zmberg avatar Dec 22 '22 04:12 zmberg

#823

zmberg avatar Apr 09 '24 03:04 zmberg

great and thank you.( I have not tested it)

martin2176 avatar Apr 09 '24 09:04 martin2176

what is the max value that is now allowed for rescheduleCriticalSeconds? Would the documentation be eventually updated to reflect this

martin2176 avatar Apr 09 '24 09:04 martin2176