kruise icon indicating copy to clipboard operation
kruise copied to clipboard

Add PostCreated Lifecycle Hook

Open veophi opened this issue 2 years ago • 1 comments

Signed-off-by: mingzhou.swx [email protected]

Ⅰ. Describe what this PR does

PostCreated lifecycle hook allow users do something before Pod become available, e.g., check whether the Pod IP has been added to SLB.

Now, the Pod lifecycle is: image

veophi avatar Sep 08 '22 08:09 veophi

Codecov Report

Merging #1071 (13969d5) into master (a639a6f) will increase coverage by 0.12%. The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   49.30%   49.43%   +0.12%     
==========================================
  Files         137      137              
  Lines       19299    19305       +6     
==========================================
+ Hits         9515     9543      +28     
+ Misses       8732     8712      -20     
+ Partials     1052     1050       -2     
Flag Coverage Δ
unittests 49.43% <81.81%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/sync/cloneset_scale.go 28.25% <33.33%> (ø)
pkg/controller/cloneset/sync/cloneset_update.go 59.92% <100.00%> (+8.75%) :arrow_up:
pkg/util/podreadiness/pod_readiness_utils.go 74.33% <100.00%> (ø)
pkg/controller/uniteddeployment/revision.go 67.02% <0.00%> (+1.06%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Nov 03 '22 09:11 codecov-commenter

/lgtm

zmberg avatar Nov 07 '22 11:11 zmberg

/approve

zmberg avatar Nov 07 '22 12:11 zmberg

/approve

furykerry avatar Nov 08 '22 02:11 furykerry

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry, zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot avatar Nov 08 '22 02:11 kruise-bot