feat(imagePullJob): add type for pullPolicy like k8s imagePullPolicy

[mmmmmmmxl]

Signed-off-by: s1ark [email protected]

Ⅰ. Describe what this PR does

When you need to overwrite/preheat the existing image or latest tag image on the machine, you need to set a PullPolicy that is the same as the ImagePullPolicy of k8s.This PR provides configuration to solve this problem.

Ⅱ. Does this pull request fix one issue?

https://github.com/openkruise/kruise/issues/1267

Ⅲ. Describe how to verify it

Everythings is ok in our cluster.

Ⅳ. Special notes for reviews

[kruise-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign fillzpp after the PR has been reviewed. You can assign the PR to them by writing /assign @fillzpp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[kruise-bot]

Welcome @mmmmmmmxl! It looks like this is your first PR to openkruise/kruise 🎉

[codecov-commenter]

Codecov Report

Merging #1065 (fad83a7) into master (bdd3efb) will increase coverage by 2.79%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   50.36%   53.15%   +2.79%     
==========================================
  Files         125      151      +26     
  Lines       17637    23737    +6100     
==========================================
+ Hits         8883    12618    +3735     
- Misses       7782     9908    +2126     
- Partials      972     1211     +239     

Flag	Coverage Δ
unittests	53.15% <ø> (+2.79%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 91 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[furykerry]

does the user need to change the imagepulljob if using always pull policy, if imagepulljob is not changed, image version will be the same, and if the existing image is pulled by the imagepuller, there will be a status record for the tag, and the kruise-daemon will not launch new imagepuller to pull the image. Please provide a use case with corresponding yaml to demonstrate how one can use the always pull policy

[mmmmmmmxl]

does the user need to change the imagepulljob if using always pull policy, if imagepulljob is not changed, image version will be the same, and if the existing image is pulled by the imagepuller, there will be a status record for the tag, and the kruise-daemon will not launch new imagepuller to pull the image. Please provide a use case with corresponding yaml to demonstrate how one can use the always pull policy

Yes, if the user wants to use the always pull policy, he needs to update the ImagePullJob. And If the user wants to update the latest image, he needs to use the following yaml. apiVersion: apps.kruise.io/v1alpha1 kind: ImagePullJob metadata: name: image-update-job-product spec: image: xxx/prod-builder:latest parallelism: 5 completionPolicy: type: Always activeDeadlineSeconds: 1200 ttlSecondsAfterFinished: 600 pullPolicy: type: Always backoffLimit: 3 timeoutSeconds: 60

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[wqj97]

Why this feature is not merged to master

[kruise-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[zmberg]

@wqj97 Sorry, can you resolve the following failed checks, for example:

And suggest your go version is 1.18.x.

[wqj97]

@wqj97 Sorry, can you resolve the following failed checks, for example:

And suggest your go version is 1.18.x.

Sorry, did you mention the wrong person?

[zmberg]

@wqj97 Sorry, can you resolve the following failed checks, for example: And suggest your go version is 1.18.x.

Sorry, did you mention the wrong person?

yes.

[kruise-bot]

@mmmmmmmxl: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.