kruise
kruise copied to clipboard
Support predownload image in ads
Ⅰ. Describe what this PR does
Support predownload image in ads
Ⅱ. Does this pull request fix one issue?
fixes #1048
Ⅲ. Describe how to verify it
create ads and change images of it, then an imagepulljob will be created. If every pods have beed updated, the imagepulljob will be deleted.
Ⅳ. Special notes for reviews
I am not sure whether it is neccessary to limit the daemonset size. I am so sorry that I did not found how to make the predownload image order correspond to the order of daemonset update.
@ABNER-1 The daemonset UT failed, could you fix it?
@ABNER-1 The daemonset UT failed, could you fix it?
The unittest init struct is complex and different from cloneset. I am reading the implements. I will fix it when I think I can get it.
Looks like these two pull_request test(other) failed due to statefulset controller. However, I have no code changes about it. @FillZpp
Codecov Report
Merging #1057 (cf1c5c6) into master (4263a74) will increase coverage by
0.61%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 49.30% 49.92% +0.61%
==========================================
Files 125 127 +2
Lines 12355 17961 +5606
==========================================
+ Hits 6092 8967 +2875
- Misses 5322 8005 +2683
- Partials 941 989 +48
Flag | Coverage Δ | |
---|---|---|
unittests | 49.92% <0.00%> (+0.61%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/daemonset/daemonset_controller.go | 40.96% <0.00%> (-1.73%) |
:arrow_down: |
...ontroller/daemonset/daemonset_predownload_image.go | 0.00% <0.00%> (ø) |
|
...oller/statefulset/statefulset_predownload_image.go | 0.00% <ø> (ø) |
|
...ontroller/advancedcronjob/advancedcronjob_utils.go | 75.00% <0.00%> (-25.00%) |
:arrow_down: |
pkg/util/cache.go | 53.84% <0.00%> (-6.16%) |
:arrow_down: |
...b/validating/broadcastjob_create_update_handler.go | 42.02% <0.00%> (-3.98%) |
:arrow_down: |
pkg/util/lock.go | 75.00% <0.00%> (-2.78%) |
:arrow_down: |
...ontroller/podreadiness/pod_readiness_controller.go | 28.78% <0.00%> (-2.59%) |
:arrow_down: |
pkg/controller/uniteddeployment/subset_control.go | 70.27% <0.00%> (-2.57%) |
:arrow_down: |
...g/webhook/pod/validating/pod_unavailable_budget.go | 61.79% <0.00%> (-2.39%) |
:arrow_down: |
... and 119 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FillZpp
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [FillZpp]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment