TruBudget icon indicating copy to clipboard operation
TruBudget copied to clipboard

#1658 api: JWT with RS256

Open SamuelPull opened this issue 10 months ago • 2 comments

Checklist

  • [x] I have followed (at least) the PR section of the contributing guide.
  • [x] I fixed all necessary PR warnings
  • [x] The commit history is clean
  • [x] The E2E tests are passing
  • [x] If possible, the issue has been divided into more subtasks
  • [x] I did a self review before requesting a review from another team member

Some other services also use JWT_SECRET in certain scenarios. Check if there are further changes needed.

  • [ ] email-notification-service
  • [ ] excel-export-service
  • [ ] blockchain

Description

How to test

  1. Set new env vars: JWT_ALGORITHM=RS256, JWT_SECRET=base 64 pem encoded private key, JWT_PUBLIC_KEY=base 64 pem encoded public key
  2. log in
  3. token cookie should be RS256
  4. do some stuff
  5. old configuration should work too (no JWT_ALGORITH, or set to HS256, no public key, whatever secret)

Closes #1658

SamuelPull avatar Apr 04 '24 14:04 SamuelPull

Warnings
:warning: No CHANGELOG added.

Generated by :no_entry_sign: dangerJS against 2184ba2e5d071299b9f74bc0a6689c4781b565f6

github-actions[bot] avatar Apr 04 '24 14:04 github-actions[bot]

NotesTime
:white_check_mark:Note for Reviewer: E2E tests on pipeline 58500 on remote server succeededFri, 12 Apr 2024 07:15:27 +0000

Generated by E2E-Test

openkfwCI avatar Apr 04 '24 14:04 openkfwCI