theoj icon indicating copy to clipboard operation
theoj copied to clipboard

Fixing alignment of actions area

Open arfon opened this issue 9 years ago • 4 comments

Right now there's a small gap between the right-hand column and the actions area. Could this be closed up? I'm struggling to do this.

screen_shot_2016-12-30_at_7_54_12_am

/ cc @marcrohloff

arfon avatar Dec 30 '16 12:12 arfon

Yes, I can fix that but do you want to? The gray is the page background. (For ex you can see it between pages). It used to be white but you changed tat in one of your commits ​

marcrohloff avatar Dec 30 '16 17:12 marcrohloff

Yes, I can fix that but do you want to?

Yeah, I think so. It looks like it's part of the content of the right-hand column in David's designs.

It used to be white but you changed that in one of your commits

Yeah, this was to reflect David's designs too. ​

arfon avatar Dec 30 '16 17:12 arfon

I brought this up a couple of weeks back. David's design has no space between the page and the right hand column. It looks great if there is just one page, but it doesn't work with the current multiple page design. Each page has a shadow to make it look like a page. This is completely lost by not having a background for the pages.

Marc ​

marcrohloff avatar Dec 30 '16 18:12 marcrohloff

Oh ok. Sorry I missed this context.

I think we should ask David to address this in a new design iteration.

On Fri, Dec 30, 2016 at 13:01, Marc Rohloff [email protected] wrote:

I brought this up a couple of weeks back.

David's design has no space between the page and the right hand column. It

looks great if there is just one page, but it doesn't work with the current

multiple page design. Each page has a shadow to make it look like a page.

This is completely lost by not having a background for the pages.

Marc

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openjournals/theoj/issues/274#issuecomment-269802225, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARgzkkY1iJ4tPmgxwJeHSXSqBBcRNuks5rNUblgaJpZM4LYLE- .

arfon avatar Dec 30 '16 18:12 arfon