Follow rubocop standards

Open enriquebrgn opened this issue 8 years ago • 2 comments

Following my issue #280, here's the PR following RuboCop's standards. If you have any questions regarding the PR or the code changes feel free to let me know. I also ran the tests and all of them passed.

Jul 15 '17 01:07 enriquebrgn

Thanks for opening this PR @arcticbarra. It's good to have a sanity check of my code :-)

That said, some of the changes in here I'm not inclined to accept, for example, I personally strongly favour explicit return statements in Ruby methods. That said, there's lots of good clean up in here which would be great to have included.

Given the size of this PR I'm going to leave it open for a while and when I get a chance I'll review and merge.

Jul 15 '17 11:07 arfon

Hi @arfon!

I already added back the return statements, if you need me to do any other changes I'll be happy to do so 😄

Jul 15 '17 14:07 enriquebrgn