joss icon indicating copy to clipboard operation
joss copied to clipboard

Contribution process for JOSS code and policies

Open sneakers-the-rat opened this issue 1 year ago • 4 comments

Continuing a discussion from slack:

When this was merged, it caused a good deal of confusion, and it became clear that we need a bit more structure around changes to the code that runs joss, and while we're at it I think we might also want to make a process for proposing changes to policies as well since the distinction between policy and code can sometimes blur together given the nature of the journal.

This is a discussion issue to gather what we might want in a more formal proposal for a contribution policy, so it will be a bit barebones to start, but the initial thing I think we want is...

  • For any PR that makes substantive changes, announce in either joss or development slack channel (which do we want?) and give 1 week comment time for everyone to be able to review. Bugfixes or other PRs that don't meaningfully change the code don't need the 1 week review time.
  • ...? (comment below and i'll add them here)

sneakers-the-rat avatar Apr 17 '24 01:04 sneakers-the-rat

Sounds like a reasonable plan to me @sneakers-the-rat !

Additions:

  • We probably some kind of proviso that for dev changes, you need a 👍 from one or more of @openjournals/dev .

arfon avatar Apr 20 '24 15:04 arfon