joss-reviews icon indicating copy to clipboard operation
joss-reviews copied to clipboard

[PRE REVIEW]: The ARC-OPT Library for Whole-Body Control of Robotic Systems

Open editorialbot opened this issue 1 year ago • 14 comments
trafficstars

Submitting author: @dmronga (Dennis Mronga) Repository: https://github.com/ARC-OPT/wbc Branch with paper.md (empty if default branch): joss Version: master Editor: @adi3 Reviewers: Pending Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4ce358bd4b2acc05b589f2883b168567"><img src="https://joss.theoj.org/papers/4ce358bd4b2acc05b589f2883b168567/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4ce358bd4b2acc05b589f2883b168567/status.svg)](https://joss.theoj.org/papers/4ce358bd4b2acc05b589f2883b168567)

Author instructions

Thanks for submitting your paper to JOSS @dmronga. Currently, there isn't a JOSS editor assigned to your paper.

@dmronga if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot avatar Mar 09 '24 08:03 editorialbot

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot avatar Mar 09 '24 08:03 editorialbot

Software report:

github.com/AlDanial/cloc v 1.90  T=0.14 s (1877.2 files/s, 284699.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                             47            269             30          22743
C++                             84           2007           1074           7881
C/C++ Header                    64            802           1290           1831
YAML                            16             68             14            856
SVG                              2              0              0            633
CMake                           45            168              1            622
Bourne Shell                     3             36             31            177
TeX                              1             19              0            176
Markdown                         3             78              0            135
diff                             6             21             50             88
-------------------------------------------------------------------------------
SUM:                           271           3468           2490          35142
-------------------------------------------------------------------------------

Commit count by author:

   568	dmronga
   194	Dennis Mronga
    42	misteronga
    36	ibergonzani
     6	Sebastian Kasperski
     3	rh5user
     2	Malte Wirkus
     2	Steffen Planthaber
     1	Bob the Builder
     1	Pierre Willenbrock
     1	Vinzenz Bargsten

editorialbot avatar Mar 09 '24 08:03 editorialbot

Paper file info:

📄 Wordcount for paper.md is 743

✅ The paper includes a Statement of need section

editorialbot avatar Mar 09 '24 08:03 editorialbot

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

editorialbot avatar Mar 09 '24 08:03 editorialbot

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/ROBOT.2006.1642100 is OK
- 10.1115/1.4045941 is OK
- 10.1007/s10514-016-9574-0 is OK
- 10.1109/ICRA.2016.7487270 is OK
- 10.1142/S0219843616500079 is OK
- 10.1109/ICRA46639.2022.9811616 is OK
- 10.3390/s22249853 is OK

MISSING DOIs

- No DOI given, and none found for title: Eiquadprog
- No DOI given, and none found for title: KDL: Kinematics and Dynamics Library
- 10.1109/humanoids47582.2021.9555770 may be a valid DOI for title: Design, analysis and control of the series-paralle...
- 10.1109/lra.2019.2926664 may be a valid DOI for title: qpSWIFT: A Real-Time Sparse Quadratic Program Solv...
- 10.15607/rss.2022.xviii.040 may be a valid DOI for title: PROX-QP: Yet another Quadratic Programming Solver ...
- 10.1142/s0219843615500449 may be a valid DOI for title: Implementing Torque Control with High-Ratio Gear B...
- 10.1007/s12532-014-0071-1 may be a valid DOI for title: qpOASES: A parametric active-set algorithm for qua...
- 10.1080/01691864.2020.1721322 may be a valid DOI for title: A Constraint-Based Approach for Human-Robot Collis...
- 10.1109/sii.2019.8700380 may be a valid DOI for title: The Pinocchio C++ library – A fast and flexible im...

INVALID DOIs

- https://doi.org/10.1016/j.robot.2021.103779 is INVALID because of 'https://doi.org/' prefix

editorialbot avatar Mar 09 '24 08:03 editorialbot

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot avatar Mar 09 '24 08:03 editorialbot

@editorialbot invite @adi3 as editor

👋 @adi3 – would you be willing to handle this submission for us?

arfon avatar Mar 09 '24 16:03 arfon

Invitation to edit this submission sent!

editorialbot avatar Mar 09 '24 16:03 editorialbot

@editorialbot commands

adi3 avatar Mar 09 '24 17:03 adi3

Hello @adi3, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

editorialbot avatar Mar 09 '24 17:03 editorialbot

@editorialbot assign @adi3 as editor

adi3 avatar Mar 09 '24 17:03 adi3

Assigned! @adi3 is now the editor

editorialbot avatar Mar 09 '24 17:03 editorialbot

@dmronga - I'll be the editor for this review. To get things going, could you please suggest 5-6 reviewers from this list that you consider appropriate to vet this paper? While selecting, you should confirm that the domain expertise of the reviewer matches the subject matter of your paper and software.

Thank you!

adi3 avatar Mar 25 '24 08:03 adi3

@adi3 Sure, can you give me access to the list?

dmronga avatar Mar 26 '24 09:03 dmronga

@dmronga I'm not an admin on the list. Simply request access through the page shown to you and I'm sure it'll be opened up to you fairly quickly.

adi3 avatar Apr 01 '24 08:04 adi3

Hey @adi3 I still don´t have access. I requested it a couple of times. Can you help me out on this?

dmronga avatar Apr 14 '24 20:04 dmronga

@dmronga - Can you say what specific steps you went through? (and please ping me - @danielskatz on your reply)

danielskatz avatar Apr 15 '24 05:04 danielskatz

Hey @danielskatz , I am asking for access for the Google Table, which works. But I don´t get any reply via mail, neither do I have access by now. Is it maybe because I am logged in with my gmail adress there? I will ask for access again right now.

dmronga avatar Apr 15 '24 07:04 dmronga

@dmronga - Can you be a bit more specific here? What google table? Where did you ask for access?

danielskatz avatar Apr 15 '24 07:04 danielskatz

@danielskatz I am clicking on this link, then I get the following:

grafik

I am asking for access, and that is it. From what I get, somebody should give me to access this file, but that did not happen up to now.

Best, Dennis

dmronga avatar Apr 15 '24 07:04 dmronga

Ah - I'm not sure where you found that, as we don't use it anymore. See the first comment in this issue, which points to https://reviewers.joss.theoj.org/lookup

danielskatz avatar Apr 15 '24 07:04 danielskatz

Ah ok, that looks better

dmronga avatar Apr 15 '24 08:04 dmronga

@adi3 I would like to suggest the following reviewers:

  1. Martin Huber @mhubii
  2. @JHartzer
  3. @gfadini
  4. @sea-bass
  5. @shravantata

dmronga avatar Apr 15 '24 08:04 dmronga

@dmronga - thanks (speaking for @adi3). In the future, please don't tag potential reviewers with the @, as this notifies them to this and future comments on the thread. We prefer to only notify the reviewers we actually invite, which is the editor's decision.

danielskatz avatar Apr 15 '24 08:04 danielskatz

hi @dmronga, I am currently already reviewing #5986.

I'd be happy to review if you know of a reviewer for #6138. This review has unfortunately been stuck lately.

mhubii avatar Apr 15 '24 09:04 mhubii

Hi everyone! The paper looks interesting and I will be happy to review it :)

ShravanTata avatar Apr 16 '24 14:04 ShravanTata

@editorialbot add @ShravanTata as reviewer

adi3 avatar Apr 22 '24 07:04 adi3

@ShravanTata added to the reviewers list!

editorialbot avatar Apr 22 '24 07:04 editorialbot

@dmronga following mhubii's proposal, would you be willing to review his publication on https://github.com/openjournals/joss-reviews/issues/6138? I'll assign him as a reviewer to this paper then. Let us know!

adi3 avatar Apr 22 '24 07:04 adi3

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot avatar Apr 23 '24 15:04 editorialbot