joss-reviews icon indicating copy to clipboard operation
joss-reviews copied to clipboard

[REVIEW]: APAV: Python for Atom Probe Tomography

Open editorialbot opened this issue 1 year ago • 5 comments

Submitting author: @jdasm (Jesse Smith) Repository: https://gitlab.com/jesseds/apav Branch with paper.md (empty if default branch): JOSS Version: v1.3.1 Editor: @rkurchin Reviewers: @aliusdragonfly, @ziatdinovmax Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ee06a37a09339a80f36b0a1ddeba6b27"><img src="https://joss.theoj.org/papers/ee06a37a09339a80f36b0a1ddeba6b27/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ee06a37a09339a80f36b0a1ddeba6b27/status.svg)](https://joss.theoj.org/papers/ee06a37a09339a80f36b0a1ddeba6b27)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@aliusdragonfly & @ziatdinovmax, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @rkurchin know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@aliusdragonfly, please create your checklist typing: @editorialbot generate my checklist

@ziatdinovmax, please create your checklist typing: @editorialbot generate my checklist

editorialbot avatar Oct 17 '22 18:10 editorialbot

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot avatar Oct 17 '22 18:10 editorialbot

Software report:

github.com/AlDanial/cloc v 1.88  T=0.52 s (150.9 files/s, 23570.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          40           1764           2088           5048
reStructuredText                21            495            219           1458
SVG                              6              3              3            376
TeX                              1             10              0            121
Markdown                         2             49              1            119
Cython                           2             43             43            118
YAML                             2             16              2            115
DOS Batch                        2             12              1             51
make                             1              4              7              9
TOML                             1              1              0              5
-------------------------------------------------------------------------------
SUM:                            78           2397           2364           7420
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

editorialbot avatar Oct 17 '22 18:10 editorialbot

Wordcount for paper.md is 1761

editorialbot avatar Oct 17 '22 18:10 editorialbot

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s43586-021-00047-w is OK
- 10.1038/s41524-020-00486-1 is OK
- 10.1016/j.ultramic.2010.11.021 is OK
- 10.1017/S1431927621012794 is OK
- 10.5281/zenodo.5570790 is OK
- 10.1080/09500830903472997 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot avatar Oct 17 '22 18:10 editorialbot

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot avatar Oct 17 '22 18:10 editorialbot

@aliusdragonfly, @ziatdinovmax, let me know if you have any questions about how to get started on your reviews!

rkurchin avatar Oct 25 '22 22:10 rkurchin

Haha. No questions on how, just trying to line up a slot for when...

Should be able to get to it Friday, at least to make a start.


From: Rachel Kurchin @.> Sent: Tuesday, October 25, 2022 6:07 PM To: openjournals/joss-reviews @.> Cc: Akey, Austin @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [REVIEW]: APAV: Python for Atom Probe Tomography (Issue #4862)

@aliusdragonflyhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_aliusdragonfly&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=i1XD4vrFod9g3xujqbMDqsMaafxF0kWNw9QOfOvB9xE&m=sZPkDoMuTkm0JHfm49t9SmbhTjzwoc9JqgPQT2F6rczrCgq_s4K_NU9fBdM3VyRx&s=fJ4xQ6GReABHzHHdRfxP42FF6kmWw_fFTtBAlkpTT_M&e=, @ziatdinovmaxhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ziatdinovmax&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=i1XD4vrFod9g3xujqbMDqsMaafxF0kWNw9QOfOvB9xE&m=sZPkDoMuTkm0JHfm49t9SmbhTjzwoc9JqgPQT2F6rczrCgq_s4K_NU9fBdM3VyRx&s=fryYVZrqutNF-cwdIugH6-O7f4RO74n5WlA0URvMtEc&e=, let me know if you have any questions about how to get started on your reviews!

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openjournals_joss-2Dreviews_issues_4862-23issuecomment-2D1291193736&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=i1XD4vrFod9g3xujqbMDqsMaafxF0kWNw9QOfOvB9xE&m=sZPkDoMuTkm0JHfm49t9SmbhTjzwoc9JqgPQT2F6rczrCgq_s4K_NU9fBdM3VyRx&s=GCnOAQ_W8gMWDYY5JXOXSJr3w0tAVaVaowesn2i8mDc&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_A3RX75H75SVRLTH4PWKNU4TWFBKY5ANCNFSM6AAAAAARHK6JGQ&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=i1XD4vrFod9g3xujqbMDqsMaafxF0kWNw9QOfOvB9xE&m=sZPkDoMuTkm0JHfm49t9SmbhTjzwoc9JqgPQT2F6rczrCgq_s4K_NU9fBdM3VyRx&s=pEkdmc2wHfFirNX4PxH43YVuS3bFX0J6bK0gFvN6dy0&e=. You are receiving this because you were mentioned.Message ID: @.***>

aliusdragonfly avatar Oct 25 '22 22:10 aliusdragonfly

Hi again reviewers (@aliusdragonfly @ziatdinovmax), reminder to get reviews started! As you work on your checklist, feel free to file issues in the project repository; if you do so, please link back to this review issue for easy tracking.

rkurchin avatar Nov 07 '22 14:11 rkurchin

@rkurchin I apologize for the delay. I will try to review it before the end of the week.

ziatdinovmax avatar Nov 07 '22 19:11 ziatdinovmax