joss-reviews icon indicating copy to clipboard operation
joss-reviews copied to clipboard

[PRE REVIEW]: Accelerated oblique random survival forests

Open editorialbot opened this issue 2 years ago • 12 comments

Submitting author: @bcjaeger (Byron Jaeger) Repository: https://github.com/bcjaeger/aorsf Branch with paper.md (empty if default branch): Version: 0.0.1 Editor: Pending Reviewers: Pending Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/414871f081cd8449007d671a7f7f7c3a"><img src="https://joss.theoj.org/papers/414871f081cd8449007d671a7f7f7c3a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/414871f081cd8449007d671a7f7f7c3a/status.svg)](https://joss.theoj.org/papers/414871f081cd8449007d671a7f7f7c3a)

Author instructions

Thanks for submitting your paper to JOSS @bcjaeger. Currently, there isn't a JOSS editor assigned to your paper.

@bcjaeger if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot avatar Aug 07 '22 06:08 editorialbot

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot avatar Aug 07 '22 06:08 editorialbot

Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (1070.6 files/s, 232200.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               43           1880           2140           3924
C++                              2           1189            997           2054
XML                              1              0              2            441
JSON                             1              0              0            270
Markdown                         6             79              0            249
YAML                             8             48             23            228
Rmd                              4            237            237            217
TeX                              1             15              0             84
-------------------------------------------------------------------------------
SUM:                            66           3448           3399           7467
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

editorialbot avatar Aug 07 '22 06:08 editorialbot

Wordcount for paper.md is 832

editorialbot avatar Aug 07 '22 06:08 editorialbot

Failed to discover a Statement of need section in paper

editorialbot avatar Aug 07 '22 06:08 editorialbot

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/ARXIV.2208.01129 is OK

MISSING DOIs

- 10.1007/978-3-030-56485-8_3 may be a valid DOI for title: Random forests
- 10.1214/19-aoas1261 may be a valid DOI for title: Oblique random survival forests
- 10.1161/circulationaha.120.053134 may be a valid DOI for title: Development and Validation of Machine Learning–Based Race-Specific Models to Predict 10-Year Risk of Heart Failure: A Multicohort Analysis
- 10.1016/j.patcog.2019.107078 may be a valid DOI for title: Heterogeneous oblique random forest

INVALID DOIs

- None

editorialbot avatar Aug 07 '22 06:08 editorialbot

@bcjaeger - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

arfon avatar Aug 07 '22 06:08 arfon

@arfon - thank you for letting me know! I totally understand. I will make some updates based on editorialbot's feedback in the meantime.

bcjaeger avatar Aug 07 '22 12:08 bcjaeger

👋 @emdupre - would you be able to edit this submission?

danielskatz avatar Aug 10 '22 13:08 danielskatz

@editorialbot invite @emdupre as editor

danielskatz avatar Aug 10 '22 13:08 danielskatz

Invitation to edit this submission sent!

editorialbot avatar Aug 10 '22 13:08 editorialbot

Thanks for thinking of me ! I'm a little concerned that I won't be able to properly evaluate this as I'm less comfortable in R, so I'll need to decline the invitation.

emdupre avatar Aug 15 '22 04:08 emdupre

@editorialbot invite @Fei-Tao as editor

:wave: @Fei-Tao – would you be willing to edit this submission for JOSS?

arfon avatar Aug 21 '22 07:08 arfon

Invitation to edit this submission sent!

editorialbot avatar Aug 21 '22 07:08 editorialbot

@editorialbot assign me as editor

Fei-Tao avatar Aug 22 '22 01:08 Fei-Tao

Assigned! @Fei-Tao is now the editor

editorialbot avatar Aug 22 '22 01:08 editorialbot

@bcjaeger If you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Fei-Tao avatar Aug 23 '22 21:08 Fei-Tao

@cole-brokamp if you'd like to review this submission, please comment here! Feel free to unsubscribe from this issue if you are not interested. Thanks for your time.

Fei-Tao avatar Aug 24 '22 13:08 Fei-Tao

Thanks! Here are a few other people who I think would be great reviewers

Terry Therneau (therneau) - a lot of the C code in aorsf is based on his survival package coxph routine.

Torsten Hothorn (thothorn) - Torsten is the author of the party package and I'd like aorsf to look like the party package in 10 years.

Hannah Frick (hfrick), Emil Hvitfeldt (EmilHvitfeldt), Max Kuhn (topepo), Davis Vaughan (DavisVaughan), and Julia Silge (juliasilge) - they are all developers/contributors to the censored package, and I'd like aorsf to contribute to that package.

Raphael Sonabend (RaphaelS1), Andreas Bender (adibender), Michel Lang (mllg), and Patrick Schratz (pat-s) - they are developers/contributors to the mlr3-proba package, and I'd like aorsf to contribute to that package.

bcjaeger avatar Aug 24 '22 13:08 bcjaeger

Oh and in case I did not mention this, aorsf was reviewed at rOpenSci: https://github.com/ropensci/software-review/issues/532

I believe this qualifies aorsf for an expedited review by JOSS, depending on how the editor views the rOpenSci review.

bcjaeger avatar Aug 24 '22 13:08 bcjaeger

@bcjaeger and @Fei-Tao - because of the rOpenSci review, this indeed does not need to go through a full JOSS review. so I'll take it and handle the expedited review (and thanks to @Fei-Tao for agreeing to edit when we didn't know this)

danielskatz avatar Aug 24 '22 13:08 danielskatz

@editorialbot assign me as editor

danielskatz avatar Aug 24 '22 13:08 danielskatz

Assigned! @danielskatz is now the editor

editorialbot avatar Aug 24 '22 13:08 editorialbot

@editorialbot generate pdf

danielskatz avatar Aug 24 '22 13:08 danielskatz

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot avatar Aug 24 '22 13:08 editorialbot

@bcjaeger - please add a statement of need section to the paper, and in that, or in the introduction, please explain more generally what this software does and what types of applications it has, remembering that JOSS has a very diverse readership, not all of which has detailed machine learning expertise. For example, the paper probably needs to explain what right-censored time-to-event data is and where it appears/is used, what survival decision trees are and where they appear/are used, what risk prediction models are and where they appear/are used, etc. While you do this, I will do a bunch of the processing needed, including creating a review issue very shortly.

danielskatz avatar Aug 24 '22 14:08 danielskatz

@editorialbot assign @danielskatz as reviewer

danielskatz avatar Aug 24 '22 14:08 danielskatz

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

editorialbot avatar Aug 24 '22 14:08 editorialbot

@editorialbot add @danielskatz as reviewer

danielskatz avatar Aug 24 '22 14:08 danielskatz

@danielskatz added to the reviewers list!

editorialbot avatar Aug 24 '22 14:08 editorialbot