joss-reviews icon indicating copy to clipboard operation
joss-reviews copied to clipboard

[PRE REVIEW]: TLViz: Visualising and analysing tensor decomposition models with Python

Open editorialbot opened this issue 2 years ago • 30 comments

Submitting author: @marieroald (Marie Roald) Repository: https://github.com/tensorly/viz Branch with paper.md (empty if default branch): paper Version: v0.1.1 Editor: @faroit Reviewers: @sara-02 Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/43044545885a3e47b35c6775530a67c0"><img src="https://joss.theoj.org/papers/43044545885a3e47b35c6775530a67c0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/43044545885a3e47b35c6775530a67c0/status.svg)](https://joss.theoj.org/papers/43044545885a3e47b35c6775530a67c0)

Author instructions

Thanks for submitting your paper to JOSS @marieroald. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @timtroendle.

@marieroald if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot avatar May 28 '22 01:05 editorialbot

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot avatar May 28 '22 01:05 editorialbot

Software report:

github.com/AlDanial/cloc v 1.88  T=0.10 s (658.9 files/s, 137805.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          36           2010           3528           4474
SVG                              3              0             53           2572
TeX                              2             33              0            333
reStructuredText                16            132            128            193
YAML                             4             15             10            132
Markdown                         1             24              0             81
DOS Batch                        1              8              1             27
TOML                             1              5              0             13
INI                              1              1              0             10
make                             1              4              6             10
-------------------------------------------------------------------------------
SUM:                            66           2232           3726           7845
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

editorialbot avatar May 28 '22 01:05 editorialbot

Wordcount for paper.md is 1176

editorialbot avatar May 28 '22 01:05 editorialbot

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-1-84800-046-9_8 is OK
- 10.1137/07070111X is OK
- 10.1016/S0169-7439(97)00032-4 is OK
- 10.1016/j.neuroimage.2004.02.026 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.1016/S0169-7439(00)00071-X is OK
- 10.21105/joss.03021 is OK
- 10.5334/jors.148 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot avatar May 28 '22 01:05 editorialbot

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot avatar May 28 '22 01:05 editorialbot

@editorialbot invite @galessiorob as editor

Kevin-Mattheus-Moerman avatar May 30 '22 09:05 Kevin-Mattheus-Moerman

Invitation to edit this submission sent!

editorialbot avatar May 30 '22 09:05 editorialbot

👋 @galessiorob - are you able to edit this submission?

danielskatz avatar May 31 '22 19:05 danielskatz

@galessiorob :wave:

Kevin-Mattheus-Moerman avatar Jun 08 '22 08:06 Kevin-Mattheus-Moerman

@danielskatz @Kevin-Mattheus-Moerman I have some experience with with parafac implementations in Python and could also think of some reviewers but I'm of course also happy @galessiorob can edit this (i could still provide some potential reviewers in that case)

faroit avatar Jun 08 '22 12:06 faroit

@faroit if you can edit this I'd be glad to assign you. Would you be okay with that? You can also do this yourself by calling @editorialbot assign me as editor. Thanks for your comment here.

Kevin-Mattheus-Moerman avatar Jun 08 '22 12:06 Kevin-Mattheus-Moerman

@editorialbot assign me as editor

faroit avatar Jun 13 '22 08:06 faroit

Assigned! @faroit is now the editor

editorialbot avatar Jun 13 '22 08:06 editorialbot

👋 Hi @MarieRoald, thanks again for your submission to JOSS. I will be serving as the editor for this now. We'll use this issue to identify reviewers and resolve technical issues.

i won't be able to start the review process before start of next week as I am currently on vacation but I will already contact some scholars that I know have worked closely with parafac and python. @MarieRoald, please feel free to also suggest a couple of reviewers yourself.

For this, please check the JOSS COI policy and only mention them with a space between the @ and their handle (so you would refer to me as "@ faroit").

faroit avatar Jun 13 '22 08:06 faroit

/ooo June 13 until June 20

faroit avatar Jun 13 '22 17:06 faroit

Hi @faroit, thank you for editing our paper!

I looked through the list of reviewers linked above, and @ jamiehadd could be a good candidate as she seems to be knowledgeable in Python and tensor factorisations for data analysis. @ ahwillia also seems like a good fit since he has experience with PARAFAC for data analysis in Python, but he is high on the list and appears to have an active review already, so he might not have the capacity.

MarieRoald avatar Jun 15 '22 10:06 MarieRoald

@MarieRoald thanks for your suggestions. I would also like to ask @ aarmey. Do you see a conflict of interest here?

faroit avatar Jun 20 '22 17:06 faroit

Hi @faroit, neither @yngvem nor I have worked with @ aarmey directly, but all three of us are involved with the TensorLy project. From the COI policy, I am not sure if this is a COI or not?

MarieRoald avatar Jun 21 '22 08:06 MarieRoald

@MarieRoald to me this looks more like a COI than not... @arfon what do you think? The submission is hosted under parent (tensorly) organization and the potential reviewer (aarmey) is part of the same parent project but hasn't contributed to this project (the submission) nor has a direct working relationship with the submitting authors.

faroit avatar Jun 21 '22 15:06 faroit

@faroit Update: We have now started discussing the possibility of more collaboration within the TensorLy team. While nothing is set in stone yet, I am now leaning more towards this being a COI.

MarieRoald avatar Jun 27 '22 17:06 MarieRoald

@MarieRoald Thanks for your transparent replies. I am currently looking for other reviewers and will let you know here

faroit avatar Jun 28 '22 16:06 faroit

👋 @ahwillia @jamiehadd @neel-dey @danielakuinchtner - would any of you be willing to review this submission for JOSS? The JOSS review process takes place on GitHub and focuses on the software and a short paper. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The software under review is Tensorly Viz.

This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place.

faroit avatar Jul 15 '22 11:07 faroit

Hi @faroit, thank you for reaching out and my apologies for the delayed response. Unfortunately, I don't have the capacity to properly review this submission at the moment.

neel-dey avatar Jul 19 '22 00:07 neel-dey

Hello @faroit @MarieRoald, this project looks cool. I will be happy to review it. I am available post 20th August to help.

sara-02 avatar Jul 27 '22 21:07 sara-02

@sara-02: Thank you, that's great! @faroit: I believe we need at least two reviewers? I looked through the list again, and here are some additional candidates I found by broadening my search to people interested in data science/machine learning:

  • canerturkmen
  • 62442katieb
  • jkbren
  • TahiriNadia

And here are some more possible candidates (outside the list) familiar with Python and tensor decompositions:

  • jvendrow
  • IlyaKisil
  • aschein

MarieRoald avatar Aug 11 '22 04:08 MarieRoald

@MarieRoald @sara-02 very sorry for the delay. I am on vacation this week, but I behind the scenes I have tried to contact a countless number of potential reviewers - without much success... I will try from your list as well now.

faroit avatar Aug 16 '22 13:08 faroit

👋 @62442katieb @IlyaKisil @jkbren @jvendrow - would any of you be willing to review this submission for JOSS? The JOSS review process takes place on GitHub and focuses on the software and a short paper. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The software under review is Tensorly Viz.

This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place.

faroit avatar Aug 16 '22 13:08 faroit

@editorialbot add @sara-02 to reviewers

faroit avatar Aug 16 '22 13:08 faroit

@sara-02 added to the reviewers list!

editorialbot avatar Aug 16 '22 13:08 editorialbot

Hi! Sorry, I don't have the bandwidth to review right now.

62442katieb avatar Aug 16 '22 18:08 62442katieb