valhalla icon indicating copy to clipboard operation
valhalla copied to clipboard

Merge lworld

Open jatin-bhateja opened this issue 1 month ago • 2 comments

Merge from lworld in lworld+vector branch.

Apart from the usual merge conflict resolution, the patch also contains bug fixes for some special handling around multifields. To segregate the code changes and maintain the history[1][2][3][4][5], these bug fixes were initially checked into a temporary private merge branch and are now part of the merge.

Validation: Status

  • Vector API JTREG tests
    • Default options:
    • With -XX:+DeoptimizeALot
    • With -XX:-UseNonAtomicValueFlattening
  • Valhalla JTREG tests

[1] Special copy constructor used for initializing base and synthetic multifields https://github.com/jatin-bhateja/valhalla/commit/0fe3153e79251fe661ea1bd368472f2f75cb360d [2] Fix ciField population for multifields https://github.com/jatin-bhateja/valhalla/commit/4a26aff14801e010ea238e8d5a52a52465c6f849 [3] Multifield handling during type domain buildup https://github.com/jatin-bhateja/valhalla/commit/74ca0245c5d9f5eb186baa962e11d3f5c8f4ed35 [4] prevent store forwarding across CPU memory barrier https://github.com/jatin-bhateja/valhalla/commit/cfc71acd89b2e3233d788565f1cf1061651a70f9 [5] Fix to accommodate additional padding during offset computation of multifields https://github.com/jatin-bhateja/valhalla/commit/75ec6296531839ab375efa58b909827269994449


Progress

  • [x] Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1688/head:pull/1688
$ git checkout pull/1688

Update a local copy of the PR:
$ git checkout pull/1688
$ git pull https://git.openjdk.org/valhalla.git pull/1688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1688

View PR using the GUI difftool:
$ git pr show -t 1688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1688.diff

jatin-bhateja avatar Oct 21 '25 01:10 jatin-bhateja

:wave: Welcome back jbhateja! A progress list of the required criteria for merging this PR into lworld+vector will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 21 '25 01:10 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Oct 21 '25 01:10 openjdk[bot]