valhalla-docs icon indicating copy to clipboard operation
valhalla-docs copied to clipboard

01-background.md: fix link in-defense-of-erasure md

Open FredeHG opened this issue 1 year ago • 6 comments
trafficstars

Udate link in-defense-of-erasure.html -> in-defense-of-erasure


Progress

  • [x] Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla-docs.git pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.org/valhalla-docs.git pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla-docs/pull/12.diff

Webrev

Link to Webrev Comment

FredeHG avatar Apr 03 '24 14:04 FredeHG

Hi @FredeHG, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user FredeHG" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

bridgekeeper[bot] avatar Apr 03 '24 14:04 bridgekeeper[bot]

@FredeHG This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

01-background.md: fix link in-defense-of-erasure md

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the main branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Apr 03 '24 14:04 openjdk[bot]

:warning: @FredeHG a branch with the same name as the source branch for this pull request (main) is present in the target repository. If you eventually integrate this pull request then the branch main in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the main branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f main 4ffb787fb00ae0c3a967e00a3bd549e14b1b634d
$ git push -f origin main

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

openjdk[bot] avatar Apr 03 '24 14:04 openjdk[bot]

/signed

FredeHG avatar Apr 04 '24 08:04 FredeHG

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

bridgekeeper[bot] avatar Apr 04 '24 08:04 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Apr 28 '24 20:04 mlbridge[bot]

@FredeHG This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 26 '24 22:05 bridgekeeper[bot]

@FredeHG This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Jun 24 '24 01:06 bridgekeeper[bot]