skara
skara copied to clipboard
2070: Get a placeholder message spot for integration message
As Magnus said in the issue description, sometimes it's hard for users to find the merge ready comment. So he would like to see that this message is added as soon as possible, after the bridgekeeper has done its job.
In this patch, on the very beginning of CheckWorkItem, skara bot would post a placeholder message to the PR and update it later.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
Issue
- SKARA-2070: Get a placeholder message spot for integration message (Bug - P3)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1619/head:pull/1619
$ git checkout pull/1619
Update a local copy of the PR:
$ git checkout pull/1619
$ git pull https://git.openjdk.org/skara.git pull/1619/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1619
View PR using the GUI difftool:
$ git pr show -t 1619
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1619.diff
Webrev
:wave: Welcome back zsong! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
Nice! Thanks for fixing this. Do you have an test PR that demonstrates how this looks?
Nice! Thanks for fixing this. Do you have an test PR that demonstrates how this looks?
No, I haven't got a test PR. I will have one on playground after this PR is integrated.
@zhaosongzs This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
:mag: One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.
After integration, the commit message for the final commit will be:
2070: Get a placeholder message spot for integration message
Reviewed-by: erikj
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 2 new commits pushed to the master
branch:
- 5b84d05ee246b63dced10f5e86456f95115cc152: 2191: Handle multiple available skara.gitconfig files
- af682b4508b48a098ff5cbd53d0db37a94cdf32b: 2190: Setting maximum size limit for PR diff in generating Webrev
Please see this link for an up-to-date comparison between the source branch of this pull request and the master
branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master
branch, type /integrate in a new comment.
Thanks for the review! /integrate
Going to push as commit 40193134ee6b2d3686d3069efc07027a847d7e64.
Since your change was applied there have been 2 commits pushed to the master
branch:
- 5b84d05ee246b63dced10f5e86456f95115cc152: 2191: Handle multiple available skara.gitconfig files
- af682b4508b48a098ff5cbd53d0db37a94cdf32b: 2190: Setting maximum size limit for PR diff in generating Webrev
Your commit was automatically rebased without conflicts.
@zhaosongzs Pushed as commit 40193134ee6b2d3686d3069efc07027a847d7e64.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.
Nice! Thanks for fixing this. Do you have an test PR that demonstrates how this looks?
Here is the test PR. You can see the edit history of this comment. https://github.com/openjdk/playground/pull/185#issuecomment-1992192423