skara icon indicating copy to clipboard operation
skara copied to clipboard

2167: Unify search methods in IssueProject

Open edvbld opened this issue 1 year ago • 3 comments

Hi all,

this patch unifies the various ways of searching that exist within JiraProejct. I also chose to expose the search method in the IssueProject since I will make use of it in later patches. This is the first patch of many that will extract the JBS specific parts from JiraProject so that JiraProject will be about JIRA and JBS specific functionality will be moved elsewhere. This refactoring is needed to allow other parts of the Skara to use JBS functionality with only an IssueProject instance (without turning JiraProject into effectively JbsProject).

Thanks, Erik


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace

Issue

  • SKARA-2167: Unify search methods in IssueProject (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1610/head:pull/1610
$ git checkout pull/1610

Update a local copy of the PR:
$ git checkout pull/1610
$ git pull https://git.openjdk.org/skara.git pull/1610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1610

View PR using the GUI difftool:
$ git pr show -t 1610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1610.diff

Webrev

Link to Webrev Comment

edvbld avatar Jan 30 '24 13:01 edvbld

:wave: Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jan 30 '24 13:01 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Jan 30 '24 13:01 mlbridge[bot]

@edvbld This pull request has been inactive for more than 3 weeks and will be automatically closed if another 3 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 05 '24 18:03 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 12 '24 17:03 openjdk[bot]

@edvbld This pull request has been inactive for more than 3 weeks and will be automatically closed if another 3 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 02 '24 17:04 bridgekeeper[bot]

@edvbld This pull request has been inactive for more than 6 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Apr 23 '24 17:04 bridgekeeper[bot]