skara icon indicating copy to clipboard operation
skara copied to clipboard

2151: Remove hardcoded reference to bugs.openjdk.org from mlbridge bot

Open zhaosongzs opened this issue 1 year ago • 4 comments

As Erik said in the issue description, previously, in WebrevStorage, there is hardcoded reference to "bugs.openjdk.org" to look up issues. However, we could get the issueTracker url from mlbridge bot and use it to generate the issue link without sending requests.

Also, previously, in WebrevStorage, issueLinker of Webrev.builder is never set, so all the code related with generating the issue link are useless in production. The webrev build would never set an issue link in index.html without issueLinker. This patch also fixes this problem.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace

Issue

  • SKARA-2151: Remove hardcoded reference to bugs.openjdk.org from mlbridge bot (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1604/head:pull/1604
$ git checkout pull/1604

Update a local copy of the PR:
$ git checkout pull/1604
$ git pull https://git.openjdk.org/skara.git pull/1604/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1604

View PR using the GUI difftool:
$ git pr show -t 1604

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1604.diff

zhaosongzs avatar Jan 19 '24 22:01 zhaosongzs

:wave: Welcome back zsong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jan 19 '24 22:01 bridgekeeper[bot]

@zhaosongzs This pull request has been inactive for more than 6 weeks and will be automatically closed if another 6 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 01 '24 22:03 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 12 '24 17:03 openjdk[bot]

@zhaosongzs This pull request has been inactive for more than 6 weeks and will be automatically closed if another 6 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 23 '24 17:04 bridgekeeper[bot]

@zhaosongzs This pull request has been inactive for more than 12 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Jun 04 '24 17:06 bridgekeeper[bot]