shenandoah icon indicating copy to clipboard operation
shenandoah copied to clipboard

8331609: GenShen: Refactor generational mode allocations

Open earthling-amzn opened this issue 10 months ago • 3 comments

  • The code for resizing and retrying young allocation requests according to what's available in the young generation has been removed. This code became redundant after the free set was rewritten and began providing the same functionality.
  • An unused field and its attendant methods were removed from ShenandoahThreadLocalData.
  • The code for managing plab expenditures and configuring other plab behavior has been moved from ShenandoahHeap into ShenandoahOldGeneration.

Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8331609: GenShen: Refactor generational mode allocations (Task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/427/head:pull/427
$ git checkout pull/427

Update a local copy of the PR:
$ git checkout pull/427
$ git pull https://git.openjdk.org/shenandoah.git pull/427/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 427

View PR using the GUI difftool:
$ git pr show -t 427

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/427.diff

Webrev

Link to Webrev Comment

earthling-amzn avatar May 02 '24 23:05 earthling-amzn

:wave: Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 02 '24 23:05 bridgekeeper[bot]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331609: GenShen: Refactor generational mode allocations

Reviewed-by: kdnilsen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 02 '24 23:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 02 '24 23:05 mlbridge[bot]

/integrate

earthling-amzn avatar May 09 '24 23:05 earthling-amzn

Going to push as commit 80e69877f807499e811ff0353d7477057fa2f63d.

openjdk[bot] avatar May 09 '24 23:05 openjdk[bot]

@earthling-amzn Pushed as commit 80e69877f807499e811ff0353d7477057fa2f63d.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 09 '24 23:05 openjdk[bot]