shenandoah icon indicating copy to clipboard operation
shenandoah copied to clipboard

8321401: GenShen: Each mutator must see FullGC before throwing OOM

Open kdnilsen opened this issue 1 year ago • 8 comments

Require each thread to observe unproductive Full GC before it throws OOM exception.


Progress

  • [ ] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)

Warnings

 ⚠️ Patch contains a binary file (test/jdk/java/util/zip/ZipFile/crash.jar)  ⚠️ Patch contains a binary file (test/jdk/java/util/zip/ZipFile/input.jar)  ⚠️ Patch contains a binary file (test/jdk/java/util/zip/ZipFile/input.zip)  ⚠️ Patch contains a binary file (test/jdk/java/util/zip/test.zip)  ⚠️ Patch contains a binary file (test/jdk/javax/management/loading/LibraryLoader/native.jar)  ⚠️ Patch contains a binary file (test/jdk/javax/swing/AbstractButton/5049549/DE1.gif)  ⚠️ Patch contains a binary file (test/jdk/javax/swing/AbstractButton/5049549/DI1.gif)  ⚠️ Patch contains a binary file (test/jdk/javax/swing/AbstractButton/5049549/DS1.gif)  ⚠️ Patch contains a binary file (test/jdk/javax/swing/AbstractButton/5049549/PR1.gif)  ⚠️ Patch contains a binary file (test/jdk/javax/swing/AbstractButton/5049549/RO1.gif)  ⚠️ Patch contains a binary file (test/jdk/javax/swing/AbstractButton/5049549/RS1.gif)  ⚠️ Patch contains a binary file (test/jdk/javax/swing/AbstractButton/5049549/SE1.gif)

Issue

  • JDK-8321401: GenShen: Each mutator must see FullGC before throwing OOM (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/365/head:pull/365
$ git checkout pull/365

Update a local copy of the PR:
$ git checkout pull/365
$ git pull https://git.openjdk.org/shenandoah.git pull/365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 365

View PR using the GUI difftool:
$ git pr show -t 365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/365.diff

Webrev

Link to Webrev Comment

kdnilsen avatar Dec 05 '23 14:12 kdnilsen

:wave: Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Dec 05 '23 14:12 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Dec 05 '23 14:12 mlbridge[bot]

There's some churn in this code, as I try to address upstream Shenandoah version of the patch first. Converting to draft until resolved.

kdnilsen avatar Dec 11 '23 03:12 kdnilsen

@kdnilsen This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Feb 05 '24 05:02 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

@kdnilsen This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 09 '24 01:05 bridgekeeper[bot]

@kdnilsen this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout fix-fullgc-race
git fetch https://git.openjdk.org/shenandoah.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk[bot] avatar May 16 '24 20:05 openjdk[bot]

@kdnilsen This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 11 '24 22:07 bridgekeeper[bot]

This is redundant with other changes already integrated upstream.

kdnilsen avatar Aug 12 '24 17:08 kdnilsen