mobile
mobile copied to clipboard
Merge jdk:master
Hi all,
this is an automatically generated pull request to notify you that there is 1 commit from the branch jdk:master
that can not be merged into the branch master
:
The following file contains merge conflicts:
- make/modules/java.base/lib/CoreLibraries.gmk
All Committers in this project have access to my personal fork and can therefore help resolve these merge conflicts (you may want to coordinate who should do this). The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request. The below commands should be run in a local clone of your personal fork of the openjdk/mobile repository.
# Ensure target branch is up to date
$ git checkout master
$ git pull https://github.com/openjdk/mobile.git master
# Fetch and checkout the branch for this pull request
$ git fetch https://github.com/openjdk-bot/mobile.git +12:openjdk-bot-12
$ git checkout openjdk-bot-12
# Merge the target branch
$ git merge master
When you have resolved the conflicts resulting from the git merge
command above, run the following commands to create a merge commit:
$ git add paths/to/files/with/conflicts
$ git commit -m 'Merge jdk:master'
When you have created the merge commit, run the following command to push the merge commit to this pull request:
$ git push https://github.com/openjdk-bot/mobile.git openjdk-bot-12:12
Note: if you are using SSH to push commits to GitHub, then change the URL in the above git push
command accordingly.
Thanks, J. Duke
/integrate auto
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/mobile.git pull/18/head:pull/18
$ git checkout pull/18
Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/mobile.git pull/18/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18
View PR using the GUI difftool:
$ git pr show -t 18
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/mobile/pull/18.diff
Webrev
:wave: Welcome back duke! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@openjdk-bot This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
Merge
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been no new commits pushed to the master
branch. If another commit should be pushed before you perform the /integrate
command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate
in a new comment. (Afterwards, your sponsor types /sponsor
in a new comment to perform the integration).
@openjdk-bot This pull request will be automatically integrated when it is ready
/integrate
@openjdk[bot] Your change (at version c9b787866b6195ffef3fd8ac1af6662ed2026dcd) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit d69bd3df33df4c33381bd8dc846adc64648a35ea.
@johanvos @openjdk-bot Pushed as commit d69bd3df33df4c33381bd8dc846adc64648a35ea.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.