loom
loom copied to clipboard
chore: Make runContinuation a ForkJoinTask.
Motivation:
Make runContinuation a ForkJoinTask to avoid adapting multi times
Progress
- [x] Change must not contain extraneous whitespace
Error
⚠️ OCA signatory status must be verified
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/loom.git pull/209/head:pull/209
$ git checkout pull/209
Update a local copy of the PR:
$ git checkout pull/209
$ git pull https://git.openjdk.org/loom.git pull/209/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 209
View PR using the GUI difftool:
$ git pr show -t 209
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/loom/pull/209.diff
Hi @He-Pin, welcome to this OpenJDK project and thanks for contributing!
We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.
If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user He-Pin" as summary for the issue.
If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
:warning: @He-Pin a branch with the same name as the source branch for this pull request (fibers) is present in the target repository. If you eventually integrate this pull request then the branch fibers in your personal fork will diverge once you sync your personal fork with the upstream repository.
To avoid this situation, create a new branch for your changes and reset the fibers branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.
$ git checkout -b NEW-BRANCH-NAME
$ git branch -f fibers 93072111f550d98604bd0c72fea0898915bdd796
$ git push -f origin fibers
Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.
@He-Pin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
/signed
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!