lilliput
lilliput copied to clipboard
8320761: [Lilliput] Implement compact identity hashcode
WIP
Progress
- [ ] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)
Integration blockers
⚠️ Too few reviewers with at least role committer found (have 0, need at least 1) (failed with updated jcheck configuration in pull request) ⚠️ Whitespace errors (failed with updated jcheck configuration in pull request)
Issue
- JDK-8320761: [Lilliput] Implement compact identity hashcode (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/lilliput.git pull/137/head:pull/137
$ git checkout pull/137
Update a local copy of the PR:
$ git checkout pull/137
$ git pull https://git.openjdk.org/lilliput.git pull/137/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 137
View PR using the GUI difftool:
$ git pr show -t 137
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/lilliput/pull/137.diff
:wave: Welcome back rkennke! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@rkennke this pull request can not be integrated into master
due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:
git checkout JDK-8320761-v2
git fetch https://git.openjdk.org/lilliput.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
⚠️ @rkennke This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch>
where <project>
is the name of another project in the OpenJDK organization (for example Merge jdk:master
).
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@rkennke This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@rkennke This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open
pull request command.