jtreg icon indicating copy to clipboard operation
jtreg copied to clipboard

7903781: Report the process id of the agent or other VM that was used for a jtreg action

Open jaikiran opened this issue 6 months ago • 3 comments

Can I please get a review of this change which proposes to repor the process id of the process that was used to run a jtreg action? This change addresses https://bugs.openjdk.org/browse/CODETOOLS-7903781.

As noted in that linked enhancement request, this change will report the process id the section messages of each action. This will now look like:

#section:compile
----------messages:(7/297)----------
command: compile test/streams/FileDescriptorTest.java
reason: .class file out of date or does not exist
started: Fri Jul 26 00:56:01 UTC 2024
Mode: othervm
Process id: 88469
finished: Fri Jul 26 00:56:01 UTC 2024
elapsed time (seconds): 0.254

....

#section:main
----------messages:(7/232)----------
command: main FileDescriptorTest
reason: User specified action: run main FileDescriptorTest 
started: Fri Jul 26 00:56:01 UTC 2024
Mode: othervm
Process id: 88470
finished: Fri Jul 26 00:56:01 UTC 2024
elapsed time (seconds): 0.042

Notice the new "Process id: ..." line in those sections.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • CODETOOLS-7903781: Report the process id of the agent or other VM that was used for a jtreg action (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/215/head:pull/215
$ git checkout pull/215

Update a local copy of the PR:
$ git checkout pull/215
$ git pull https://git.openjdk.org/jtreg.git pull/215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 215

View PR using the GUI difftool:
$ git pr show -t 215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/215.diff

Webrev

Link to Webrev Comment

jaikiran avatar Jul 26 '24 05:07 jaikiran