jtreg
jtreg copied to clipboard
7903765: wget failed in build.sh in jtreg
Can I get a review of this change which proposes to address the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7903765? This is an alternative approach that we decided to take when reviewing the original PR for this issue https://github.com/openjdk/jtreg/pull/211.
In this change, when passing destination directories for downloading source archives of asmtools and jtharness, we pass the absolute path instead of paths containing relative path elements (like ../
). This change prevents wget
running into an issue when dealing with destination directories containing ../
path element.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- CODETOOLS-7903765: wget failed in build.sh in jtreg (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/214/head:pull/214
$ git checkout pull/214
Update a local copy of the PR:
$ git checkout pull/214
$ git pull https://git.openjdk.org/jtreg.git pull/214/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 214
View PR using the GUI difftool:
$ git pr show -t 214
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/214.diff