jmh
jmh copied to clipboard
openjdk
7903618: JMH: Add power events to perf profilers
The Linux tool perf provides collecting energy consumption via Intel's RAPL API. Today's climate crisis does not need to have tools to be as performant as possible it also requires software to be as energy efficient as possible. Thus measuring the energy consumption of processes is a crucial tool.
Progress
- [x] Change must not contain extraneous whitespace
- [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)
Issue
- CODETOOLS-7903618: JMH: Add power events to perf profilers (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/126/head:pull/126
$ git checkout pull/126
Update a local copy of the PR:
$ git checkout pull/126
$ git pull https://git.openjdk.org/jmh.git pull/126/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 126
View PR using the GUI difftool:
$ git pr show -t 126
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/126.diff
Webrev
Hi @schrieveslaach, welcome to this OpenJDK project and thanks for contributing!
We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.
If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user schrieveslaach" as summary for the issue.
If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!
@schrieveslaach Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@schrieveslaach Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
Nice initiative, although repl does not report the idle power consumption...
Could you also go to https://github.com/schrieveslaach/jmh/actions -- and enable testing workflows for your fork? This would test things. Thanks!
@schrieveslaach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@schrieveslaach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@schrieveslaach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
@schrieveslaach Do you still have interest in completing this? If not, I can take over.
@schrieveslaach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@schrieveslaach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.