8219: Missing coverage in application reports

[aptmac]

This PR fixes (&cleans up) the coverage reports under jmc/application.

The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage.

Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well.

The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated.

---

Progress

• [x] Commit message must refer to an issue
• [x] Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8219: Missing coverage in application reports (Bug - P4)

Reviewers

• Christoph Langer (@RealCLanger - Reviewer) ⚠️ Review applies to 29b13465
• Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/562/head:pull/562
$ git checkout pull/562

Update a local copy of the PR:
$ git checkout pull/562
$ git pull https://git.openjdk.org/jmc.git pull/562/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 562

View PR using the GUI difftool:
$ git pr show -t 562

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/562.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8219: Missing coverage in application reports

Reviewed-by: clanger, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• eead0934233e3d01839faf6e71bb6ae8985ee5f9: 8266: Upgrade third party libraries for JMC 9.1.0
• f114fb50d5447af55bda7c2b2a2b8e76765e0740: 8259: Several JFR pages throwing exceptions after JMC-8244

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge[bot]]

Webrevs

• 08: Full (4a5ba2b7)
• 07: Full (653ae413)
• 06: Full (991c21c0)
• 05: Full (6e6948dc)
• 04: Full (54edc15f)
• 03: Full - Incremental (61fb9f65)
• 02: Full (29b13465)
• 01: Full (2944c261)
• 00: Full (3eb1f9c2)

[aptmac]

Ah right, no surefireargline if it's being run without coverage, so that's tanking the tests.

[openjdk[bot]]

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[bridgekeeper[bot]]

@aptmac This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[aptmac]

Updated the branch to sit on-top of master to pull in the new Jolokia feature. This also required the addition of the tycho.testArgLine.local to the argLine used when running the tests so the coverage could be recorded.

[bridgekeeper[bot]]

@aptmac This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[thegreystone]

Branch has conflicts.

[openjdk[bot]]

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk[bot]]

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk[bot]]

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk[bot]]

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk[bot]]

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[aptmac]

Trying these checks again, locally it ran fine and then it ran cleanly after nuking my local m2 and starting again.

[thegreystone]

Ok. Let's take it, but be prepared to follow up with a fix if the integration goes bad.